fix: add envFollowKubernetesPattern to handle k8s-like format env in helm templates

[g1eny0ung]

Signed-off-by: Yue Yang g1enyy0ung@gmail.com

What problem does this PR solve?

Close #2924

What's changed and how it works?

{{/*
Handle env variables.

TODO: in the future, we would like to use the k8s-like format for defining environment variables.
So the `envFollowKubernetesPattern` will become to `env`.
And the original way of writing env will be removed.
Ref: https://github.com/chaos-mesh/chaos-mesh/pull/2955.
*/}}
{{- define "chaos-mesh.helpers.list-env-vars" -}}
{{- with .envFollowKubernetesPattern }}
{{ toYaml . }}
{{- end }}
{{- range $key, $val := .env }}
- name: {{ $key | upper }}
  value: {{ $val | quote }}
{{- end }}
{{- end }}

Related changes

• Need to update chaos-mesh/website
• Need to update Dashboard UI
• Need to cheery-pick to release branches
  • release-2.1
  • release-2.0

Checklist

Tests

• Unit test
• E2E test
• No code
• Manual test (add steps below)

Side effects

• Breaking backward compatibility

Release note

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• STRRL
• iguoyr

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[STRRL]

So in the PR, we could set valueFrom like

dashboard:
  env:
    SOME_SECRET:
      valueFrom:
        secretKeyRef:
          name: some-secret
          key: token

It does not follow the K: V, neither follows the kubneretes like name: <name> then value: <value>.  😰

Maybe we could create another new field near the origin env field, and follows the kubernetes-like format.

[g1eny0ung]

So in the PR, we could set valueFrom like

dashboard:
  env:
    SOME_SECRET:
      valueFrom:
        secretKeyRef:
          name: some-secret
          key: token

It does not follow the K: V, neither follows the kubneretes like name: <name> then value: <value>.  😰

Maybe we could create another new field near the origin env field, and follows the kubernetes-like format.

But our current env also doesn't conform to the k8s-like format. I have no problem with using another field, but maybe we should make env a k8s-like format in a future release? (means that the key: value format can no longer be used in env)

[STRRL]

maybe we should make env a k8s-like format in a future release? (means that the key: value format can no longer be used in env)

I agree with you. Maybe we could change the current env as the k8s-like format, and we should notice that in the upgrade manual doc.

[g1eny0ung]

Updated. @STRRL PTAL.

[iguoyr]

Rest LGTM

[iguoyr]

LGTM

[g1eny0ung]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 3250a21

[ti-srebot]

cherry pick to release-2.1 failed