-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refine logging in pkg time #2964
chore: refine logging in pkg time #2964
Conversation
Signed-off-by: STRRL <str_ruiling@outlook.com>
Signed-off-by: STRRL <str_ruiling@outlook.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #2964 +/- ##
==========================================
- Coverage 37.98% 37.96% -0.02%
==========================================
Files 106 105 -1
Lines 9106 9108 +2
==========================================
- Hits 3459 3458 -1
- Misses 5340 5344 +4
+ Partials 307 306 -1
Continue to review full report at Codecov.
|
Signed-off-by: STRRL <str_ruiling@outlook.com>
@STRRL: GitHub didn't allow me to request PR reviews from the following users: STRRL. Note that only chaos-mesh members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: SiyuChen <ryougi201@gmail.com> Signed-off-by: STRRL <str_ruiling@outlook.com>
dcd7c52
to
a37cc21
Compare
Updated! PTAL @iguoyr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: a37cc21
|
/merge |
1 similar comment
/merge |
cherry pick to release-2.1 failed |
Waiting for #2991 |
* chore: refine logging in pkg time Signed-off-by: STRRL <str_ruiling@outlook.com> * chore: keep consist with darwin API Signed-off-by: STRRL <str_ruiling@outlook.com> * chore: make check Signed-off-by: STRRL <str_ruiling@outlook.com> * Update pkg/time/asset.go Co-authored-by: SiyuChen <ryougi201@gmail.com> Signed-off-by: STRRL <str_ruiling@outlook.com> Co-authored-by: SiyuChen <ryougi201@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
* chore: refine logging in pkg time Signed-off-by: STRRL <str_ruiling@outlook.com> * chore: keep consist with darwin API Signed-off-by: STRRL <str_ruiling@outlook.com> * chore: make check Signed-off-by: STRRL <str_ruiling@outlook.com> * Update pkg/time/asset.go Co-authored-by: SiyuChen <ryougi201@gmail.com> Signed-off-by: STRRL <str_ruiling@outlook.com> Co-authored-by: SiyuChen <ryougi201@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Co-authored-by: SiyuChen <ryougi201@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Co-authored-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: STRRL str_ruiling@outlook.com
What problem does this PR solve?
close #2889
What's changed and how it works?
FakeImage
,SkewClockGetTime
,SkewGetTimeOfDay
Related changes
chaos-mesh/website
Dashboard UI
Checklist
Tests
Side effects
Release note
DCO
If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it: