Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refine logging in pkg time #2964

Merged
merged 5 commits into from
Mar 8, 2022

Conversation

STRRL
Copy link
Member

@STRRL STRRL commented Mar 2, 2022

Signed-off-by: STRRL str_ruiling@outlook.com

What problem does this PR solve?

close #2889

What's changed and how it works?

  • add fields logger for FakeImage, SkewClockGetTime, SkewGetTimeOfDay
  • update related function signatures

Related changes

  • Need to update chaos-mesh/website
  • Need to update Dashboard UI
  • Need to cheery-pick to release branches
    • release-2.1
    • release-2.0

Checklist

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

Side effects

  • Breaking backward compatibility

Release note

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

Signed-off-by: STRRL <str_ruiling@outlook.com>
Signed-off-by: STRRL <str_ruiling@outlook.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 2, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Hexilee
  • iguoyr

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #2964 (eb07ff3) into master (57832f7) will decrease coverage by 0.01%.
The diff coverage is 83.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2964      +/-   ##
==========================================
- Coverage   37.98%   37.96%   -0.02%     
==========================================
  Files         106      105       -1     
  Lines        9106     9108       +2     
==========================================
- Hits         3459     3458       -1     
- Misses       5340     5344       +4     
+ Partials      307      306       -1     
Impacted Files Coverage Δ
pkg/time/fake_image_linux_amd64.go 51.56% <0.00%> (ø)
pkg/time/time_skew_amd64.go 54.23% <71.42%> (ø)
pkg/chaosdaemon/time_server.go 87.23% <100.00%> (ø)
pkg/time/asset.go 64.28% <100.00%> (+2.74%) ⬆️
pkg/time/fake_image.go 100.00% <100.00%> (+100.00%) ⬆️
pkg/time/time_linux_amd64.go 28.57% <100.00%> (ø)
.../workflow/controllers/workflow_entry_reconciler.go 48.14% <0.00%> (-6.88%) ⬇️
pkg/workflow/controllers/chaos_node_reconciler.go 58.16% <0.00%> (+2.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57832f7...eb07ff3. Read the comment docs.

Signed-off-by: STRRL <str_ruiling@outlook.com>
@STRRL STRRL mentioned this pull request Mar 3, 2022
9 tasks
@STRRL
Copy link
Member Author

STRRL commented Mar 4, 2022

/cc
@Hexilee @Andrewmatilde

@ti-chi-bot
Copy link
Member

@STRRL: GitHub didn't allow me to request PR reviews from the following users: STRRL.

Note that only chaos-mesh members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc
@Hexilee @Andrewmatilde

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@STRRL
Copy link
Member Author

STRRL commented Mar 4, 2022

PTAL

/cc @Andrewmatilde @iguoyr

Copy link
Member

@Hexilee Hexilee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/time/asset.go Outdated Show resolved Hide resolved
Co-authored-by: SiyuChen <ryougi201@gmail.com>
Signed-off-by: STRRL <str_ruiling@outlook.com>
@STRRL STRRL force-pushed the refine-logging-in-pkg-time branch from dcd7c52 to a37cc21 Compare March 7, 2022 10:03
@STRRL
Copy link
Member Author

STRRL commented Mar 7, 2022

Updated! PTAL @iguoyr

Copy link
Member

@iguoyr iguoyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@STRRL
Copy link
Member Author

STRRL commented Mar 7, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a37cc21

@STRRL
Copy link
Member Author

STRRL commented Mar 7, 2022

/merge

1 similar comment
@STRRL
Copy link
Member Author

STRRL commented Mar 8, 2022

/merge

@ti-chi-bot ti-chi-bot merged commit 1ae6711 into chaos-mesh:master Mar 8, 2022
@ti-srebot
Copy link
Contributor

cherry pick to release-2.1 failed

@STRRL
Copy link
Member Author

STRRL commented Mar 10, 2022

cherry pick to release-2.1 failed

Waiting for #2991

STRRL added a commit to STRRL/chaos-mesh that referenced this pull request Mar 21, 2022
* chore: refine logging in pkg time

Signed-off-by: STRRL <str_ruiling@outlook.com>

* chore: keep consist with darwin API

Signed-off-by: STRRL <str_ruiling@outlook.com>

* chore: make check

Signed-off-by: STRRL <str_ruiling@outlook.com>

* Update pkg/time/asset.go

Co-authored-by: SiyuChen <ryougi201@gmail.com>
Signed-off-by: STRRL <str_ruiling@outlook.com>

Co-authored-by: SiyuChen <ryougi201@gmail.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
g1eny0ung added a commit that referenced this pull request Aug 8, 2022
* chore: refine logging in pkg time

Signed-off-by: STRRL <str_ruiling@outlook.com>

* chore: keep consist with darwin API

Signed-off-by: STRRL <str_ruiling@outlook.com>

* chore: make check

Signed-off-by: STRRL <str_ruiling@outlook.com>

* Update pkg/time/asset.go

Co-authored-by: SiyuChen <ryougi201@gmail.com>
Signed-off-by: STRRL <str_ruiling@outlook.com>

Co-authored-by: SiyuChen <ryougi201@gmail.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>

Co-authored-by: SiyuChen <ryougi201@gmail.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Co-authored-by: Yue Yang <g1enyy0ung@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants