Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dashboard API for StatusCheck #2972

Merged
merged 17 commits into from
Mar 30, 2022

Conversation

iguoyr
Copy link
Member

@iguoyr iguoyr commented Mar 3, 2022

Signed-off-by: SiyuChen ryougi201@gmail.com

What problem does this PR solve?

Close #2968

What's changed and how it works?

Add dashboard api for status check

Related changes

  • Need to update chaos-mesh/website
  • Need to update Dashboard UI
  • Need to cheery-pick to release branches
    • release-2.1
    • release-2.0

Checklist

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

Side effects

  • Breaking backward compatibility

Release note

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

Signed-off-by: SiyuChen <ryougi201@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 3, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • STRRL
  • cwen0

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested review from STRRL and yeya24 March 3, 2022 11:49
@iguoyr iguoyr changed the title Add dashboard api for status check Add dashboard API for StatusCheck Mar 3, 2022
Signed-off-by: SiyuChen <ryougi201@gmail.com>
Signed-off-by: SiyuChen <ryougi201@gmail.com>
@ti-chi-bot ti-chi-bot added size/XL and removed size/M labels Mar 4, 2022
Signed-off-by: SiyuChen <ryougi201@gmail.com>
Signed-off-by: SiyuChen <ryougi201@gmail.com>
@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #2972 (c1272e5) into master (9e02a05) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2972      +/-   ##
==========================================
- Coverage   37.95%   37.88%   -0.07%     
==========================================
  Files         105      105              
  Lines        9095     9095              
==========================================
- Hits         3452     3446       -6     
- Misses       5335     5340       +5     
- Partials      308      309       +1     
Impacted Files Coverage Δ
pkg/workflow/controllers/chaos_node_reconciler.go 55.87% <0.00%> (-2.30%) ⬇️
pkg/workflow/controllers/utils.go 87.30% <0.00%> (+1.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e02a05...c1272e5. Read the comment docs.

@iguoyr iguoyr marked this pull request as ready for review March 15, 2022 09:51
Signed-off-by: SiyuChen <ryougi201@gmail.com>
…board-api

Signed-off-by: SiyuChen <ryougi201@gmail.com>
Signed-off-by: SiyuChen <ryougi201@gmail.com>
Signed-off-by: SiyuChen <ryougi201@gmail.com>
@iguoyr iguoyr requested review from g1eny0ung and a team March 16, 2022 06:27
@iguoyr iguoyr removed the request for review from yeya24 March 16, 2022 06:27
@iguoyr
Copy link
Member Author

iguoyr commented Mar 16, 2022

@STRRL @g1eny0ung @chaos-mesh/committers
PTAL

Signed-off-by: SiyuChen <ryougi201@gmail.com>
@iguoyr
Copy link
Member Author

iguoyr commented Mar 24, 2022

/cc @chaos-mesh/committers @chaos-mesh/maintainers
PTAL

@ti-chi-bot ti-chi-bot requested a review from a team March 24, 2022 05:34
Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @iguoyr Do you have a plan to store these templates in Chaos Dashboard as archive data when these were deleted?

Copy link
Member

@STRRL STRRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@STRRL
Copy link
Member

STRRL commented Mar 29, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5513193

@iguoyr
Copy link
Member Author

iguoyr commented Mar 29, 2022

LGTM! @iguoyr Do you have a plan to store these templates in Chaos Dashboard as archive data when these were deleted?

No such plan for now, I think archiving templates is useless, because templates are static resources. 🤔

@cwen0
Copy link
Member

cwen0 commented Mar 29, 2022

/run-e2e-test

@ti-chi-bot ti-chi-bot merged commit 065b268 into chaos-mesh:master Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: StatusCheck in Workflow, Add Dashboard API for StatusCheck
4 participants