Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong zero value of httpchaos replace body action #2990

Merged
merged 2 commits into from
Mar 8, 2022

Conversation

Hexilee
Copy link
Member

@Hexilee Hexilee commented Mar 8, 2022

What problem does this PR solve?

Close #2988

What's changed and how it works?

Replace field Body of PodHttpChaosReplaceActions with a pointer.

Related changes

  • Need to update chaos-mesh/website
  • Need to update Dashboard UI
  • Need to cheery-pick to release branches
    • release-2.1
    • release-2.0

Checklist

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

Side effects

  • Breaking backward compatibility

Release note

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

Signed-off-by: xixi <i@hexilee.me>
Signed-off-by: xixi <i@hexilee.me>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 8, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Andrewmatilde
  • YangKeao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@Hexilee Hexilee requested review from Andrewmatilde and YangKeao and removed request for Colstuwjx and fewdan March 8, 2022 04:42
@Hexilee Hexilee added the type/bug-fix A bug needs to be fixed. label Mar 8, 2022
@Andrewmatilde
Copy link
Member

/run-e2e-test

@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #2990 (e695b0a) into master (1ae6711) will decrease coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2990      +/-   ##
==========================================
- Coverage   38.18%   37.99%   -0.19%     
==========================================
  Files         105      105              
  Lines        9108     9108              
==========================================
- Hits         3478     3461      -17     
- Misses       5325     5341      +16     
- Partials      305      306       +1     
Impacted Files Coverage Δ
.../workflow/controllers/workflow_entry_reconciler.go 46.03% <0.00%> (-9.00%) ⬇️
pkg/workflow/controllers/deadline_reconciler.go 64.44% <0.00%> (-5.19%) ⬇️
pkg/workflow/controllers/chaos_node_reconciler.go 59.59% <0.00%> (+1.43%) ⬆️
pkg/workflow/controllers/utils.go 87.30% <0.00%> (+1.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ae6711...e695b0a. Read the comment docs.

Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Andrewmatilde Andrewmatilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hexilee
Copy link
Member Author

Hexilee commented Mar 8, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e695b0a

@ti-chi-bot ti-chi-bot merged commit f52ad7d into chaos-mesh:master Mar 8, 2022
@STRRL
Copy link
Member

STRRL commented Mar 8, 2022

Hi @Hexilee please append CHANGELOG for this bugfix.

And do we need to cherry-pick this PR into release-2.1?

@Hexilee
Copy link
Member Author

Hexilee commented Mar 8, 2022

Hi @Hexilee please append CHANGELOG for this bugfix.

And do we need to cherry-pick this PR into release-2.1?

I'm sorry to forget that, I will create another PR to update CHANGELOG. This bug is introduced after release-2.1, so it's unnecessary to cherry-pick.

@Hexilee Hexilee mentioned this pull request Mar 25, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zero value config of httpchaos replace action cause wrong behavior
5 participants