-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix wrong zero value of httpchaos replace body action #2990
Conversation
Signed-off-by: xixi <i@hexilee.me>
Signed-off-by: xixi <i@hexilee.me>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-e2e-test |
Codecov Report
@@ Coverage Diff @@
## master #2990 +/- ##
==========================================
- Coverage 38.18% 37.99% -0.19%
==========================================
Files 105 105
Lines 9108 9108
==========================================
- Hits 3478 3461 -17
- Misses 5325 5341 +16
- Partials 305 306 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: e695b0a
|
Hi @Hexilee please append CHANGELOG for this bugfix. And do we need to cherry-pick this PR into release-2.1? |
I'm sorry to forget that, I will create another PR to update CHANGELOG. This bug is introduced after release-2.1, so it's unnecessary to cherry-pick. |
What problem does this PR solve?
Close #2988
What's changed and how it works?
Replace field Body of PodHttpChaosReplaceActions with a pointer.
Related changes
chaos-mesh/website
Dashboard UI
Checklist
Tests
Side effects
Release note
DCO
If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it: