Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add the missing context.Context param in bpm/build_darwin #2996

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

g1eny0ung
Copy link
Member

Signed-off-by: Yue Yang g1enyy0ung@gmail.com

What problem does this PR solve?

It's a small mistake I have found (I use mac vscode and the static checker always complains that many errors occurred).

What's changed and how it works?

Add the missing context.Context param in Build().

Related changes

  • Need to update chaos-mesh/website
  • Need to update Dashboard UI
  • Need to cheery-pick to release branches
    • release-2.1
    • release-2.0

Checklist

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

Side effects

  • Breaking backward compatibility

Release note

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
@g1eny0ung g1eny0ung added the type/bug-fix A bug needs to be fixed. label Mar 9, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 9, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • WangXiangUSTC
  • YangKeao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #2996 (6a7f4ee) into master (f52ad7d) will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2996      +/-   ##
==========================================
+ Coverage   37.96%   38.14%   +0.17%     
==========================================
  Files         105      105              
  Lines        9108     9108              
==========================================
+ Hits         3458     3474      +16     
+ Misses       5344     5332      -12     
+ Partials      306      302       -4     
Impacted Files Coverage Δ
pkg/selector/generic/mode.go 25.64% <0.00%> (-2.57%) ⬇️
.../workflow/controllers/workflow_entry_reconciler.go 46.03% <0.00%> (-2.12%) ⬇️
pkg/workflow/controllers/task_reconciler.go 6.70% <0.00%> (+0.80%) ⬆️
pkg/workflow/controllers/serial_node_reconciler.go 61.13% <0.00%> (+1.55%) ⬆️
...g/workflow/controllers/parallel_node_reconciler.go 62.02% <0.00%> (+1.89%) ⬆️
pkg/workflow/controllers/deadline_reconciler.go 74.07% <0.00%> (+9.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f52ad7d...6a7f4ee. Read the comment docs.

Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YangKeao
Copy link
Member

YangKeao commented Mar 9, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6a7f4ee

@cwen0
Copy link
Member

cwen0 commented Mar 9, 2022

/run-e2e-test

@ti-chi-bot ti-chi-bot merged commit d215648 into chaos-mesh:master Mar 9, 2022
@g1eny0ung g1eny0ung deleted the fix/bpm_build_darwin branch March 9, 2022 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants