-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move GetService out of package pod selector #3003
refactor: move GetService out of package pod selector #3003
Conversation
Signed-off-by: STRRL <str_ruiling@outlook.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: STRRL <str_ruiling@outlook.com>
Codecov Report
@@ Coverage Diff @@
## master #3003 +/- ##
==========================================
- Coverage 38.20% 38.06% -0.14%
==========================================
Files 105 105
Lines 9108 9094 -14
==========================================
- Hits 3480 3462 -18
- Misses 5323 5328 +5
+ Partials 305 304 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PTAL, @YangKeao |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: f80305f
|
Signed-off-by: STRRL str_ruiling@outlook.com
What problem does this PR solve?
Refactoring
pkg/selector/pod
, moveGetService
near to DNSChaos implementation, make it unexported, and remove the unused parameterWhat's changed and how it works?
Related changes
chaos-mesh/website
Dashboard UI
Checklist
Tests
It could be compiled with no error.
Side effects
Release note
DCO
If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it: