Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JVMChaos: return error with information #3004

Merged
merged 6 commits into from
Mar 10, 2022

Conversation

WangXiangUSTC
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC commented Mar 10, 2022

What problem does this PR solve?

fix issue: #2746

When executing bmsubmit.sh or bminstall.sh failed, only return error exit status 1, doesn't contain the real error information. So return the error and warp the output of comamnds.

What's changed and how it works?

Related changes

  • Need to update chaos-mesh/website
  • Need to update Dashboard UI
  • Need to cheery-pick to release branches
    • release-2.1
    • release-2.0

Checklist

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

Side effects

  • Breaking backward compatibility

Release note

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

Signed-off-by: xiang <xiang13225080@163.com>
Signed-off-by: xiang <xiang13225080@163.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 10, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • YangKeao
  • cwen0

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: xiang <xiang13225080@163.com>
@ti-chi-bot ti-chi-bot added size/L and removed size/XS labels Mar 10, 2022
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good 👍

@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #3004 (b6dcce3) into master (84e432d) will increase coverage by 0.16%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3004      +/-   ##
==========================================
+ Coverage   38.08%   38.24%   +0.16%     
==========================================
  Files         105      105              
  Lines        9094     9094              
==========================================
+ Hits         3463     3478      +15     
+ Misses       5325     5311      -14     
+ Partials      306      305       -1     
Impacted Files Coverage Δ
pkg/chaosdaemon/jvm_server.go 0.00% <0.00%> (ø)
pkg/workflow/controllers/deadline_reconciler.go 64.44% <0.00%> (-5.19%) ⬇️
pkg/selector/generic/mode.go 28.20% <0.00%> (+2.56%) ⬆️
pkg/workflow/controllers/chaos_node_reconciler.go 61.31% <0.00%> (+3.15%) ⬆️
.../workflow/controllers/workflow_entry_reconciler.go 52.91% <0.00%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d73ff71...b6dcce3. Read the comment docs.

Signed-off-by: xiang <xiang13225080@163.com>
@ti-chi-bot ti-chi-bot added size/XS and removed size/L labels Mar 10, 2022
Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member

cwen0 commented Mar 10, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 697cdee

@WangXiangUSTC
Copy link
Contributor Author

/run-e2e-tests

@ti-chi-bot ti-chi-bot merged commit 2f18784 into chaos-mesh:master Mar 10, 2022
haizi-cui pushed a commit to haizi-cui/chaos-mesh that referenced this pull request Mar 11, 2022
* add error infomation

Signed-off-by: xiang <xiang13225080@163.com>

* format code

Signed-off-by: xiang <xiang13225080@163.com>

* remove file

Signed-off-by: xiang <xiang13225080@163.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Signed-off-by: cuixh@maycur.com <cuixh@maycur.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants