Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix chaos-daemon selection bug in ctrlserver #3017

Merged
merged 4 commits into from
Mar 14, 2022

Conversation

Hexilee
Copy link
Member

@Hexilee Hexilee commented Mar 14, 2022

What problem does this PR solve?

Close #3007

What's changed and how it works?

Straightly select daemon pods by k8s client.

Related changes

  • Need to update chaos-mesh/website
  • Need to update Dashboard UI
  • Need to cheery-pick to release branches
    • release-2.1
    • release-2.0

Checklist

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

Side effects

  • Breaking backward compatibility

Release note

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

Signed-off-by: xixi <i@hexilee.me>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 14, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Andrewmatilde
  • STRRL

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@Hexilee Hexilee requested a review from STRRL March 14, 2022 10:09
@Hexilee Hexilee added the type/bug-fix A bug needs to be fixed. label Mar 14, 2022
Signed-off-by: xixi <i@hexilee.me>
@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #3017 (1b7a366) into master (7c114d6) will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3017      +/-   ##
==========================================
- Coverage   38.12%   37.98%   -0.15%     
==========================================
  Files         105      105              
  Lines        9094     9094              
==========================================
- Hits         3467     3454      -13     
- Misses       5320     5333      +13     
  Partials      307      307              
Impacted Files Coverage Δ
.../workflow/controllers/workflow_entry_reconciler.go 46.03% <0.00%> (-6.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c114d6...1b7a366. Read the comment docs.

Copy link
Member

@STRRL STRRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@Andrewmatilde Andrewmatilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hexilee
Copy link
Member Author

Hexilee commented Mar 14, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 20edb8d

@ti-chi-bot ti-chi-bot merged commit 2ba4962 into chaos-mesh:master Mar 14, 2022
@ti-srebot
Copy link
Contributor

cherry pick to release-2.1 failed

@cwen0
Copy link
Member

cwen0 commented Mar 15, 2022

@Hexilee You need to cherry-pick this pr to release-2.1 manually.

@Hexilee
Copy link
Member Author

Hexilee commented Mar 15, 2022

@Hexilee You need to cherry-pick this pr to release-2.1 manually.

Done

ti-chi-bot added a commit that referenced this pull request Mar 21, 2022
Signed-off-by: xixi <i@hexilee.me>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chaosctl might not works with clusterScoped=false
6 participants