Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine logging in pkg/dashboard/apiserver/workflow #3035

Merged
merged 3 commits into from
Mar 21, 2022

Conversation

iguoyr
Copy link
Member

@iguoyr iguoyr commented Mar 16, 2022

Signed-off-by: SiyuChen ryougi201@gmail.com

What problem does this PR solve?

Close #2877

What's changed and how it works?

Move package level variable log into struct Service as a field.

Related changes

  • Need to update chaos-mesh/website
  • Need to update Dashboard UI
  • Need to cheery-pick to release branches
    • release-2.1
    • release-2.0

Checklist

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

Side effects

  • Breaking backward compatibility

Release note

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

Signed-off-by: SiyuChen <ryougi201@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 16, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • STRRL
  • WangXiangUSTC

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: SiyuChen <ryougi201@gmail.com>
@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #3035 (b264c79) into master (32dce15) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3035      +/-   ##
==========================================
+ Coverage   37.98%   38.02%   +0.04%     
==========================================
  Files         105      105              
  Lines        9094     9094              
==========================================
+ Hits         3454     3458       +4     
+ Misses       5333     5330       -3     
+ Partials      307      306       -1     
Impacted Files Coverage Δ
.../workflow/controllers/workflow_entry_reconciler.go 48.14% <0.00%> (+2.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32dce15...b264c79. Read the comment docs.

@iguoyr iguoyr requested review from STRRL and a team March 17, 2022 03:55
Copy link
Member

@STRRL STRRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iguoyr
Copy link
Member Author

iguoyr commented Mar 21, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e8e54f6

@ti-chi-bot ti-chi-bot merged commit cbcdec1 into chaos-mesh:master Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants