Implement StatusCheck Reconciler #3037
Conversation
Signed-off-by: SiyuChen <ryougi201@gmail.com>
Signed-off-by: SiyuChen <ryougi201@gmail.com>
Signed-off-by: SiyuChen <ryougi201@gmail.com>
…nciler Signed-off-by: SiyuChen <ryougi201@gmail.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
iguoyr
added
type/enhancement
Codecov Report
@@ Coverage Diff @@
## master #3037 +/- ##
==========================================
+ Coverage 36.46% 38.01% +1.54%
==========================================
Files 109 116 +7
Lines 10044 10535 +491
==========================================
+ Hits 3663 4005 +342
- Misses 6046 6184 +138
- Partials 335 346 +11
Continue to review full report at Codecov.
|
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
Signed-off-by: SiyuChen <ryougi201@gmail.com>
Signed-off-by: SiyuChen <ryougi201@gmail.com>
Signed-off-by: SiyuChen <ryougi201@gmail.com>
Signed-off-by: SiyuChen <ryougi201@gmail.com>
Signed-off-by: SiyuChen <ryougi201@gmail.com>
Signed-off-by: SiyuChen <ryougi201@gmail.com>
|
@chaos-mesh/committers @chaos-mesh/maintainers PTAL |
|
And tests in |
|
@STRRL Updated, PTAL! |
There was a problem hiding this comment.
For me, if the error is returned by other methods in the same package, and there are no other necessary context to be attached, the errors.Wrap could be omitted.
I forget where to introduce this rule, but it seems to be a rule of a linter. I would append the reference if I find it one day.
Please append comments for them, with the reference to another method like "if you changed the logic at [here], you must change the logic at [there] for keeping the logic consistent." |
| func Test_isThresholdExceed(t *testing.T) { | ||
| type args struct { | ||
| records []v1alpha1.StatusCheckRecord | ||
| want v1alpha1.StatusCheckOutcome |
There was a problem hiding this comment.
maybe change a name other than want, it is a little ambiguous with following want in tests(out of args)
There was a problem hiding this comment.
Actually it was auto-generated by GoLand 😢, do you have any suggestions to instead want?
There was a problem hiding this comment.
Fixed! (I found that I misunderstand your point before 😢)
Signed-off-by: SiyuChen <ryougi201@gmail.com>
|
@STRRL Updated! PTAL again ❤️ |
Signed-off-by: SiyuChen <ryougi201@gmail.com>
…nciler Signed-off-by: SiyuChen <ryougi201@gmail.com>
Signed-off-by: SiyuChen <ryougi201@gmail.com>
Signed-off-by: SiyuChen <ryougi201@gmail.com>
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 34e3305
|
What problem does this PR solve?
Close #2983
What's changed and how it works?
Proposal: Workflow Status Check
Related changes
chaos-mesh/websiteDashboard UIChecklist
Tests
Side effects
Release note
DCO
If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it: