Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: tidy comments in values and readme #3053

Merged
merged 5 commits into from
Mar 30, 2022

Conversation

STRRL
Copy link
Member

@STRRL STRRL commented Mar 23, 2022

Signed-off-by: STRRL str_ruiling@outlook.com

What problem does this PR solve?

It's a part of #3015

What's changed and how it works?

  • tidy/sync up/reorder comments in helm chart values.yaml and README.md
  • remove two unused helm values:
    • dashboard.env.DATABASE_SECRET
    • dnsServer.runtime

Related changes

  • Need to update chaos-mesh/website
  • Need to update Dashboard UI
  • Need to cheery-pick to release branches
    • release-2.1
    • release-2.0

Checklist

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

Side effects

  • Breaking backward compatibility

Release note

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

Signed-off-by: STRRL <str_ruiling@outlook.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 23, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • YangKeao
  • cwen0

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@STRRL
Copy link
Member Author

STRRL commented Mar 23, 2022

Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: STRRL <str_ruiling@outlook.com>
@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #3053 (635d497) into master (00768bf) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3053      +/-   ##
==========================================
+ Coverage   38.16%   38.18%   +0.02%     
==========================================
  Files         105      105              
  Lines        9095     9095              
==========================================
+ Hits         3471     3473       +2     
+ Misses       5318     5316       -2     
  Partials      306      306              
Impacted Files Coverage Δ
pkg/workflow/controllers/utils.go 87.30% <0.00%> (+1.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54a5f88...635d497. Read the comment docs.

helm/chaos-mesh/README.md Outdated Show resolved Hide resolved
Signed-off-by: STRRL <str_ruiling@outlook.com>
@cwen0 cwen0 requested a review from iguoyr March 25, 2022 10:04
Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iguoyr
Copy link
Member

iguoyr commented Mar 25, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bad9a23

@cwen0
Copy link
Member

cwen0 commented Mar 28, 2022

/run-e2e-test

@STRRL
Copy link
Member Author

STRRL commented Mar 28, 2022

/merge

@cwen0
Copy link
Member

cwen0 commented Mar 29, 2022

/run-e2e-test

@STRRL
Copy link
Member Author

STRRL commented Mar 29, 2022

/run-e2e-tests

1 similar comment
@cwen0
Copy link
Member

cwen0 commented Mar 29, 2022

/run-e2e-tests

@ti-chi-bot ti-chi-bot merged commit 9e02a05 into chaos-mesh:master Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants