-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: tidy comments in values and readme #3053
chore: tidy comments in values and readme #3053
Conversation
Signed-off-by: STRRL <str_ruiling@outlook.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: STRRL <str_ruiling@outlook.com>
Codecov Report
@@ Coverage Diff @@
## master #3053 +/- ##
==========================================
+ Coverage 38.16% 38.18% +0.02%
==========================================
Files 105 105
Lines 9095 9095
==========================================
+ Hits 3471 3473 +2
+ Misses 5318 5316 -2
Partials 306 306
Continue to review full report at Codecov.
|
Signed-off-by: STRRL <str_ruiling@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: bad9a23
|
/run-e2e-test |
/merge |
/run-e2e-test |
/run-e2e-tests |
1 similar comment
/run-e2e-tests |
Signed-off-by: STRRL str_ruiling@outlook.com
What problem does this PR solve?
It's a part of #3015
What's changed and how it works?
values.yaml
andREADME.md
dashboard.env.DATABASE_SECRET
dnsServer.runtime
Related changes
chaos-mesh/website
Dashboard UI
Checklist
Tests
Side effects
Release note
DCO
If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it: