bump go to 1.18

[Hexilee]

Signed-off-by: xixi i@hexilee.me

What problem does this PR solve?

go 1.18 is released! It introduces generics, which may improve our development effectiveness.

What's changed and how it works?

Related changes

• Need to update chaos-mesh/website
• Need to update Dashboard UI
• Need to cheery-pick to release branches
  • release-2.1
  • release-2.0

Checklist

Tests

• Unit test
• E2E test
• No code
• Manual test (add steps below)

Side effects

• Breaking backward compatibility

Release note

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• STRRL
• YangKeao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[Hexilee]

wait for #3038

[codecov]

Codecov Report

Merging #3055 (9847060) into master (00768bf) will decrease coverage by 0.29%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3055      +/-   ##
==========================================
- Coverage   38.16%   37.86%   -0.30%     
==========================================
  Files         105      105              
  Lines        9095     9095              
==========================================
- Hits         3471     3444      -27     
- Misses       5318     5342      +24     
- Partials      306      309       +3     

Impacted Files	Coverage Δ
.../workflow/controllers/workflow_entry_reconciler.go	46.03% <0.00%> (-9.00%)	⬇️
pkg/selector/generic/mode.go	25.64% <0.00%> (-2.57%)	⬇️
pkg/workflow/controllers/chaos_node_reconciler.go	55.87% <0.00%> (-2.30%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2c627e...9847060. Read the comment docs.

[STRRL]

please append an description in CHANGELOG

[Hexilee]

please append an description in CHANGELOG

Done

[YangKeao]

/run-e2e-tests

[YangKeao]

LGTM

[STRRL]

/run-e2e-tests

[Hexilee]

/run-e2e-tests

[Hexilee]

/run-e2e-tests

[Andrewmatilde]

Please fix build error in e2e-test.

[STRRL]

Please fix build error in e2e-test.

It does not look like a build error, images could be built successful, and the test report shows several messages after kind startup:

gzip: stdin: unexpected end of file
tar: Unexpected EOF in archive
tar: Unexpected EOF in archive
tar: Error is not recoverable: exiting now

I downloaded the logs but find nothing useful...

I prefer to think that kind failed to load image from host docker into kind docker.

Anyhow, I would try to trigger the e2e tests again.

[STRRL]

/run-e2e-tests

[Andrewmatilde]

Please fix build error in e2e-test.

It does not look like a build error, images could be built successful, and the test report shows several messages after kind startup:

gzip: stdin: unexpected end of file
tar: Unexpected EOF in archive
tar: Unexpected EOF in archive
tar: Error is not recoverable: exiting now

I downloaded the logs but find nothing useful...

I prefer to think that kind failed to load image from host docker into kind docker.

Anyhow, I would try to trigger the e2e tests again.

I agree with you , but I think it is not a good idea to skip the error now , the problem may happen in any other PRs after this merge.

[STRRL]

I agree with you , but I think it is not a good idea to skip the error now , the problem may happen in any other PRs after this merge.

Which error? Did I miss anything? 🤪

[Andrewmatilde]

I agree with you , but I think it is not a good idea to skip the error now , the problem may happen in any other PRs after this merge.

Which error? Did I miss anything? 🤪

I think the error is , the e2e-test is totally unstable.

[STRRL]

I think the error is , the e2e-test is totally unstable.

We would migrate e2e tests onto GitHub Action which includes a much better networking environment. It would reduce the failure caused by the networking issue. 🥲

even after migration, I think we also need time to turn the performance of it.

But the logic of e2e tests itself make it would not be stable as unit tests: it makes asserts based on time. And I do NOT think it would be better in short future(several weeks). 🥲

After we received the computing resources from CNCF, I think we could start to think about how to make the CI experience better, like test reporting, and statistics.

[Andrewmatilde]

I agree with you . It seems at least two PR have e2e-test problem now. Can we just ingore these error & merge ?

[STRRL]

I agree with you . It seems at least two PR have e2e-test problem now. Can we just ingore these error & merge ?

I suggest NEVER do that. IMO, bypassing these CI would bring the challenge/break the determined checks. 🥲🥲🥲

I think we should suffer from it, build the correct recognition of CI, which is the last line between human's wild thoughts and engineering.

Until we improve/fix the performance of CI.

[STRRL]

Hi @Hexilee, I think we should update go version with actions/setup-go: .github/workflows/integration_test.yml:22

There are still several recipes in makefile still not using dev-env.

/cc @YangKeao

[Hexilee]

Oops, updated.

[STRRL]

LGTM!

[STRRL]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 9847060

[YangKeao]

/merge

[Hexilee]

E2E tests Failed too many times, maybe we should wait for #2986

[STRRL]

E2E tests Failed too many times, maybe we should wait for #2986

It seems the networking Jenkins back to normal, let me take another retry

[STRRL]

/merge