-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stress: add field to set the oom score #3070
Conversation
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #3070 +/- ##
==========================================
- Coverage 38.20% 37.97% -0.23%
==========================================
Files 105 105
Lines 9098 9108 +10
==========================================
- Hits 3476 3459 -17
- Misses 5315 5340 +25
- Partials 307 309 +2
Continue to review full report at Codecov.
|
}) | ||
} | ||
if stresschaos.Spec.Stressors.MemoryStressor != nil { | ||
req.OomScoreAdj = int64(stresschaos.Spec.Stressors.MemoryStressor.OOMScoreAdj) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why use int64
here? I found that everything else uses int
except for proto.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the size of int
depends on the implementation but is not part of the go language, the gRPC
only allows using int32
or int64
.
But anyway, I should use int32
here. I have submitted a commit to turn it into int32
.
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@YangKeao Can you fix CI first? |
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @YangKeao Remember to create an issue to trace the implementation of this feature on chaos dashboard.
/merge |
This pull request has been accepted and is ready to merge. Commit hash: a9accf2
|
@YangKeao: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: YangKeao yangkeao@chunibyo.icu
What problem does this PR solve?
#3069, but still need to modify the document after this PR merged.
What's changed and how it works?
Add a new field to represent the
oom_score_adj
value of the mem stress process. Thechaos-daemon
will usechoom
to execute the process and set theoom_score_adj
. If this value is set to-1000
, the oom killer will always kill the target container.Related changes
chaos-mesh/website
Dashboard UI