Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhysicalMachineChaos: add recover command in process #3084

Merged
merged 3 commits into from
Apr 1, 2022

Conversation

WangXiangUSTC
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC commented Mar 31, 2022

Signed-off-by: xiang xiang13225080@163.com

What problem does this PR solve?

Since chaos-mesh/chaosd#122 add a recover-cmd for process kill, this pr update the API and supported it in Chaos Mesh

What's changed and how it works?

Add a new field in PhysicalMachineChaos' spec

Related changes

  • Need to update chaos-mesh/website
  • Need to update Dashboard UI
  • Need to cheery-pick to release branches
    • release-2.1
    • release-2.0

Checklist

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

Side effects

  • Breaking backward compatibility

Release note

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

Signed-off-by: xiang <xiang13225080@163.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 31, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • FingerLeader
  • fewdan

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@WangXiangUSTC
Copy link
Contributor Author

/build-image

@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #3084 (14d60bc) into master (d574350) will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3084      +/-   ##
==========================================
+ Coverage   38.19%   38.35%   +0.16%     
==========================================
  Files         105      105              
  Lines        9182     9182              
==========================================
+ Hits         3507     3522      +15     
+ Misses       5366     5354      -12     
+ Partials      309      306       -3     
Impacted Files Coverage Δ
.../workflow/controllers/workflow_entry_reconciler.go 48.14% <0.00%> (+2.11%) ⬆️
pkg/workflow/controllers/chaos_node_reconciler.go 61.31% <0.00%> (+3.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d574350...14d60bc. Read the comment docs.

@github-actions
Copy link

You can download and import the image with following commands:

./hack/download-image.sh -r chaos-mesh/chaos-mesh -i 2069415317

Copy link
Member

@fewdan fewdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@FingerLeader FingerLeader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member

cwen0 commented Apr 1, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d184478

@WangXiangUSTC
Copy link
Contributor Author

/merge

@STRRL
Copy link
Member

STRRL commented Apr 1, 2022

/run-e2e-tests

@ti-srebot
Copy link
Contributor

cherry pick to release-2.1 in PR #3468

ti-chi-bot pushed a commit that referenced this pull request Jul 21, 2022
* add recover command in process

Signed-off-by: xiang <xiang13225080@163.com>

* update change log

Signed-off-by: xiang.wang <xiang.wang@shopee.com>

* update change log

Signed-off-by: xiang.wang <xiang.wang@shopee.com>

Co-authored-by: xiang <xiang13225080@163.com>
Co-authored-by: xiang.wang <xiang.wang@shopee.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants