Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug: cpu stress can not reach pod limit in some situation #3102

Merged
merged 2 commits into from
Apr 7, 2022
Merged

fix bug: cpu stress can not reach pod limit in some situation #3102

merged 2 commits into from
Apr 7, 2022

Conversation

xlgao-zju
Copy link
Member

@xlgao-zju xlgao-zju commented Apr 7, 2022 •
edited

What problem does this PR solve?

close #3100

What's changed and how it works?

Related changes

  • Need to update chaos-mesh/website
  • Need to update Dashboard UI
  • Need to cheery-pick to release branches
    • release-2.1
    • release-2.0

Checklist

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

set cpu stress experiment cpu 3 and cpu-load 30 and the resource limit of target pod is 500m

then we got: the cpu usage reaches about 500m

Side effects

  • Breaking backward compatibility

Release note 

add --cpu-load-slice 10 --cpu-method sqrt args for cpu stress by default

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 7, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • STRRL
  • YangKeao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@xlgao-zju
Copy link
Member Author

ping @STRRL @FingerLeader for review

@STRRL STRRL requested review from STRRL and FingerLeader April 7, 2022 03:29
STRRL
STRRL reviewed Apr 7, 2022
View reviewed changes
Copy link
Member

@STRRL STRRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Basic LGTM!

Please take a look on the comments

api/v1alpha1/stresschaos_types.go Outdated Show resolved Hide resolved
api/v1alpha1/stresschaos_types.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 7, 2022 •
edited

Codecov Report

Merging #3102 (a2c8ccf) into master (456ef44) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3102      +/-   ##
==========================================
+ Coverage   38.18%   38.19%   +0.01%     
==========================================
  Files         106      106              
  Lines        9343     9343              
==========================================
+ Hits         3568     3569       +1     
+ Misses       5464     5463       -1     
  Partials      311      311
Impacted Files Coverage Δ
.../workflow/controllers/workflow_entry_reconciler.go 52.91% <0.00%> (-2.12%) ⬇️
pkg/workflow/controllers/chaos_node_reconciler.go 59.02% <0.00%> (+0.85%) ⬆️
pkg/workflow/controllers/utils.go 87.30% <0.00%> (+1.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 456ef44...a2c8ccf. Read the comment docs.

@ti-chi-bot ti-chi-bot added size/S and removed size/XS labels Apr 7, 2022
@xlgao-zju
Copy link
Member Author

@STRRL updated, PTAL

@xlgao-zju
fix bug: cpu stress can not reach pod limit in some situation
8beaa4d 
Signed-off-by: xianglingao <xianglingao@tencent.com>
@xlgao-zju
Copy link
Member Author

@STRRL updated

STRRL
STRRL approved these changes Apr 7, 2022
View reviewed changes
Copy link
Member

@STRRL STRRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution!

YangKeao
YangKeao approved these changes Apr 7, 2022
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YangKeao
Copy link
Member

YangKeao commented Apr 7, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8beaa4d

@ti-chi-bot ti-chi-bot merged commit 079e42a into chaos-mesh:master Apr 7, 2022
@ti-srebot
Copy link
Contributor

cherry pick to release-2.1 failed

@STRRL
Copy link
Member

STRRL commented Apr 7, 2022

cherry pick to release-2.1 failed

I would manually cherry pick it.

@STRRL STRRL mentioned this pull request Apr 7, 2022
Merged
9 tasks
STRRL pushed a commit to STRRL/chaos-mesh that referenced this pull request Apr 7, 2022
@xlgao-zju @ti-chi-bot @STRRL
fix bug: cpu stress can not reach pod limit in some situation (chaos-…
5a90ebd 
…mesh#3102)

Signed-off-by: xianglingao <xianglingao@tencent.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
@STRRL STRRL mentioned this pull request Apr 7, 2022
Merged
9 tasks
@xlgao-zju xlgao-zju deleted the fix-cpu-stress branch April 7, 2022 06:41
ti-chi-bot added a commit that referenced this pull request Apr 7, 2022
@STRRL @xlgao-zju @ti-chi-bot
fix bug: cpu stress can not reach pod limit in some situation (#3102) (…
2d200a0 
…#3106)

* fix bug: cpu stress can not reach pod limit in some situation (#3102)

Signed-off-by: xianglingao <xianglingao@tencent.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>

* chore: update chagenlog

Signed-off-by: STRRL <str_ruiling@outlook.com>

Co-authored-by: Xianglin Gao <xlgao@zju.edu.cn>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
ti-chi-bot added a commit that referenced this pull request Apr 7, 2022
@STRRL @ti-chi-bot
chore: append changelog for #3102 (#3105)
b7fde3d 
Signed-off-by: STRRL <str_ruiling@outlook.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YangKeao YangKeao YangKeao approved these changes

@STRRL STRRL STRRL approved these changes

@WangXiangUSTC WangXiangUSTC Awaiting requested review from WangXiangUSTC

@FingerLeader FingerLeader Awaiting requested review from FingerLeader

Assignees
No one assigned
Labels
contribution first-time-contributor needs-cherry-pick-release-2.1 size/S status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cpu stress can not reach pod limit in some situation
5 participants
@xlgao-zju @ti-chi-bot @YangKeao @ti-srebot @STRRL