Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix panic when cpu or memory stress start time is nil #3104

Merged
merged 2 commits into from
Apr 7, 2022

Conversation

xlgao-zju
Copy link
Member

What problem does this PR solve?

What's changed and how it works?

Related changes

  • Need to update chaos-mesh/website
  • Need to update Dashboard UI
  • Need to cheery-pick to release branches
    • release-2.1
    • release-2.0

Checklist

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)
    create cpu or memory stress experiment, and then delete them. chaos controller will not panic

Side effects

  • Breaking backward compatibility

Release note

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

Signed-off-by: xianglingao <xianglingao@tencent.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 7, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • WangXiangUSTC
  • iguoyr

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #3104 (156f4c1) into master (079e42a) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3104      +/-   ##
==========================================
+ Coverage   38.02%   38.08%   +0.05%     
==========================================
  Files         106      106              
  Lines        9343     9343              
==========================================
+ Hits         3553     3558       +5     
+ Misses       5478     5472       -6     
- Partials      312      313       +1     
Impacted Files Coverage Δ
pkg/workflow/controllers/chaos_node_reconciler.go 55.87% <0.00%> (-2.30%) ⬇️
.../workflow/controllers/workflow_entry_reconciler.go 55.02% <0.00%> (+6.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 079e42a...156f4c1. Read the comment docs.

Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@iguoyr iguoyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iguoyr
Copy link
Member

iguoyr commented Apr 7, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 76e0f61

@ti-chi-bot
Copy link
Member

@xlgao-zju: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@xlgao-zju
Copy link
Member Author

/run-e2e-test

@xlgao-zju
Copy link
Member Author

seems I can not re-trigger the test...

@iguoyr
Copy link
Member

iguoyr commented Apr 7, 2022

/run-e2e-tests

@ti-chi-bot ti-chi-bot merged commit 1d07f06 into chaos-mesh:master Apr 7, 2022
@xlgao-zju xlgao-zju deleted the fix-panic branch April 7, 2022 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants