-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix panic when cpu or memory stress start time is nil #3104
Conversation
Signed-off-by: xianglingao <xianglingao@tencent.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #3104 +/- ##
==========================================
+ Coverage 38.02% 38.08% +0.05%
==========================================
Files 106 106
Lines 9343 9343
==========================================
+ Hits 3553 3558 +5
+ Misses 5478 5472 -6
- Partials 312 313 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 76e0f61
|
@xlgao-zju: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-e2e-test |
seems I can not re-trigger the test... |
/run-e2e-tests |
What problem does this PR solve?
What's changed and how it works?
Related changes
chaos-mesh/website
Dashboard UI
Checklist
Tests
create cpu or memory stress experiment, and then delete them. chaos controller will not panic
Side effects
Release note
DCO
If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it: