Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some typos #3109

Merged
merged 3 commits into from
Apr 10, 2022
Merged

fix some typos #3109

merged 3 commits into from
Apr 10, 2022

Conversation

xlgao-zju
Copy link
Member

Signed-off-by: xianglingao xianglingao@tencent.com

What problem does this PR solve?

What's changed and how it works?

Related changes

  • Need to update chaos-mesh/website
  • Need to update Dashboard UI
  • Need to cheery-pick to release branches
    • release-2.1
    • release-2.0

Checklist

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

Side effects

  • Breaking backward compatibility

Release note 

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

@xlgao-zju
fix some typo
071a73c 
Signed-off-by: xianglingao <xianglingao@tencent.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 8, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • STRRL
  • cwen0

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from iguoyr April 8, 2022 09:01
@ti-chi-bot ti-chi-bot requested a review from STRRL April 8, 2022 09:01
cwen0
cwen0 approved these changes Apr 8, 2022
View reviewed changes
Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

WangXiangUSTC
WangXiangUSTC approved these changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

STRRL
STRRL approved these changes Apr 8, 2022
View reviewed changes
Copy link
Member

@STRRL STRRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ❤️

@STRRL
Copy link
Member

STRRL commented Apr 8, 2022

/merge

@codecov
Copy link

codecov bot commented Apr 8, 2022 •
edited

Codecov Report

Merging #3109 (79c0518) into master (f9a443d) will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3109      +/-   ##
==========================================
- Coverage   38.11%   37.99%   -0.12%     
==========================================
  Files         106      106              
  Lines        9359     9359              
==========================================
- Hits         3567     3556      -11     
- Misses       5482     5491       +9     
- Partials      310      312       +2
Impacted Files Coverage Δ
pkg/workflow/controllers/chaos_node_reconciler.go 58.16% <0.00%> (-3.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9a443d...79c0518. Read the comment docs.

@STRRL
Copy link
Member

STRRL commented Apr 8, 2022

oops, as the comments of CRD changed, the yaml manifest also needs updates.

Please execute make check on your local machine, then commit the changes. It would re-generate the manifests.

STRRL
STRRL requested changes Apr 8, 2022
View reviewed changes
Copy link
Member

@STRRL STRRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, as the comments of CRD changed, the yaml manifest also needs updates.

Please execute make check on your local machine, then commit the changes. It would re-generate the manifests.

@STRRL
Copy link
Member

STRRL commented Apr 8, 2022

/merge cancel

@xlgao-zju
fix some typos
79c0518 
Signed-off-by: Xianglin <xianglingao@tencent.com>
@ti-chi-bot ti-chi-bot added size/L and removed size/XS labels Apr 8, 2022
@xlgao-zju
Copy link
Member Author

@STRRL updated, look like we fix so many typos, lol

STRRL
STRRL approved these changes Apr 8, 2022
View reviewed changes
Copy link
Member

@STRRL STRRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@STRRL
Copy link
Member

STRRL commented Apr 8, 2022

PTAL

/cc @cwen0 @WangXiangUSTC

@ti-chi-bot ti-chi-bot requested a review from cwen0 April 8, 2022 11:08
@cwen0
Copy link
Member

cwen0 commented Apr 10, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 79c0518

@ti-chi-bot ti-chi-bot merged commit fa57f2e into chaos-mesh:master Apr 10, 2022
@ti-srebot ti-srebot mentioned this pull request Apr 10, 2022
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-2.1 in PR #3111

@xlgao-zju xlgao-zju deleted the fix-typo branch April 10, 2022 12:18
ti-chi-bot pushed a commit that referenced this pull request Apr 14, 2022
@ti-srebot @xlgao-zju
fix some typos (#3109) (#3111)
2c60829 
* fix some typo

Signed-off-by: xianglingao <xianglingao@tencent.com>

* fix some typos

Signed-off-by: Xianglin <xianglingao@tencent.com>

Co-authored-by: xianglingao <xianglingao@tencent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@STRRL STRRL STRRL approved these changes

@cwen0 cwen0 cwen0 approved these changes

@iguoyr iguoyr Awaiting requested review from iguoyr

@WangXiangUSTC WangXiangUSTC Awaiting requested review from WangXiangUSTC

Assignees
No one assigned
Labels
contribution needs-cherry-pick-release-2.1 size/L status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@xlgao-zju @ti-chi-bot @STRRL @cwen0 @ti-srebot @WangXiangUSTC