Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate cpu load #3117

Merged
merged 3 commits into from
Apr 13, 2022
Merged

validate cpu load #3117

merged 3 commits into from
Apr 13, 2022

Conversation

xlgao-zju
Copy link
Member

@xlgao-zju xlgao-zju commented Apr 11, 2022

What problem does this PR solve?

Close #3064

What's changed and how it works?

Related changes

  • Need to update chaos-mesh/website
  • Need to update Dashboard UI
  • Need to cheery-pick to release branches
    • release-2.1
    • release-2.0

Checklist

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

set cpu stress load 150

then I get

error.api.internal_server_error: admission webhook "vstresschaos.kb.io" denied the request: Spec.Stressors.CPUStressor.Load: Invalid value: 150: valid cpu load is from 0 to 100
Side effects

image

  • Breaking backward compatibility

Release note

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 11, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • STRRL
  • iguoyr

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@xlgao-zju
Copy link
Member Author

/cc @FingerLeader

@STRRL
Copy link
Member

STRRL commented Apr 12, 2022

Maybe we could use kubebuilder:validation:Maximum and kubebuilder:validation:Minimum to archive this easier. 🙈

And both the edge values 0 and 100 should be included as the valid vlaues.

@STRRL
Copy link
Member

STRRL commented Apr 12, 2022

please execute make check to regenerate the yaml manifests. ❤️

Signed-off-by: xianglingao <xianglingao@tencent.com>
@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #3117 (7ddd6f3) into master (59cfaba) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3117      +/-   ##
==========================================
- Coverage   38.01%   37.97%   -0.05%     
==========================================
  Files         106      106              
  Lines        9359     9359              
==========================================
- Hits         3558     3554       -4     
- Misses       5490     5491       +1     
- Partials      311      314       +3     
Impacted Files Coverage Δ
pkg/workflow/controllers/deadline_reconciler.go 64.44% <0.00%> (-5.19%) ⬇️
pkg/selector/generic/mode.go 25.64% <0.00%> (-2.57%) ⬇️
pkg/workflow/controllers/chaos_node_reconciler.go 55.87% <0.00%> (-2.30%) ⬇️
.../workflow/controllers/workflow_entry_reconciler.go 52.91% <0.00%> (+6.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 420ba3e...7ddd6f3. Read the comment docs.

@xlgao-zju
Copy link
Member Author

@STRRL updated

Copy link
Member

@STRRL STRRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@iguoyr iguoyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@STRRL
Copy link
Member

STRRL commented Apr 12, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c3d0343

@xlgao-zju
Copy link
Member Author

/run-e2e-tests

@xlgao-zju
Copy link
Member Author

maybe we can rerun the failed tests periodically, if the PR has status/can-merge label.

@ti-chi-bot ti-chi-bot merged commit e3ff95e into chaos-mesh:master Apr 13, 2022
@xlgao-zju xlgao-zju deleted the validate-cpu-load branch April 13, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

STRESS TEST load over 100 will not take effect
4 participants