Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine logging in pkg/dashboard/collector/server.go #3123

Merged
merged 3 commits into from
Apr 14, 2022
Merged

Refine logging in pkg/dashboard/collector/server.go #3123

merged 3 commits into from
Apr 14, 2022

Conversation

z1cheng
Copy link
Contributor

@z1cheng z1cheng commented Apr 12, 2022

Signed-off-by: z1cheng imchench@gmail.com

What problem does this PR solve?

Close #2879

What's changed and how it works?

Related changes

  • Need to update chaos-mesh/website
  • Need to update Dashboard UI
  • Need to cheery-pick to release branches
    • release-2.1
    • release-2.0

Checklist

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

Side effects

  • Breaking backward compatibility

Release note

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 12, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • fewdan
  • iguoyr

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #3123 (28ecf27) into master (e3ff95e) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3123      +/-   ##
==========================================
- Coverage   38.10%   38.05%   -0.05%     
==========================================
  Files         106      106              
  Lines        9359     9359              
==========================================
- Hits         3566     3562       -4     
- Misses       5481     5484       +3     
- Partials      312      313       +1     
Impacted Files Coverage Δ
pkg/selector/generic/mode.go 25.64% <0.00%> (-2.57%) ⬇️
pkg/workflow/controllers/utils.go 85.71% <0.00%> (-1.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3ff95e...28ecf27. Read the comment docs.

Copy link
Member

@iguoyr iguoyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

pkg/dashboard/collector/server.go Outdated Show resolved Hide resolved
@z1cheng
Copy link
Contributor Author

z1cheng commented Apr 13, 2022

Rest LGTM

@iguoyr Fixed, thanks for reminding~

Copy link
Member

@iguoyr iguoyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

z1cheng and others added 3 commits April 13, 2022 16:03
Signed-off-by: z1cheng <imchench@gmail.com>
Signed-off-by: z1cheng <imchench@gmail.com>
Co-authored-by: SiyuChen <ryougi201@gmail.com>
Signed-off-by: z1cheng <imchench@gmail.com>
Copy link
Member

@fewdan fewdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iguoyr
Copy link
Member

iguoyr commented Apr 14, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 28ecf27

@ti-chi-bot ti-chi-bot merged commit 8f10165 into chaos-mesh:master Apr 14, 2022
@z1cheng z1cheng deleted the z1cheng/refactor_collector_server_logger branch April 14, 2022 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants