-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine logging in pkg/dashboard/collector/server.go #3123
Refine logging in pkg/dashboard/collector/server.go #3123
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #3123 +/- ##
==========================================
- Coverage 38.10% 38.05% -0.05%
==========================================
Files 106 106
Lines 9359 9359
==========================================
- Hits 3566 3562 -4
- Misses 5481 5484 +3
- Partials 312 313 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
@iguoyr Fixed, thanks for reminding~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: z1cheng <imchench@gmail.com>
Signed-off-by: z1cheng <imchench@gmail.com>
Co-authored-by: SiyuChen <ryougi201@gmail.com> Signed-off-by: z1cheng <imchench@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 28ecf27
|
Signed-off-by: z1cheng imchench@gmail.com
What problem does this PR solve?
Close #2879
What's changed and how it works?
Related changes
chaos-mesh/website
Dashboard UI
Checklist
Tests
Side effects
Release note
DCO
If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it: