Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: new check for changelog #3148

Merged
merged 8 commits into from
Apr 20, 2022
Merged

Conversation

STRRL
Copy link
Member

@STRRL STRRL commented Apr 18, 2022

Signed-off-by: STRRL im@strrl.dev

What problem does this PR solve?

close #3134

What's changed and how it works?

  • new label "no-need-update-changelog"
  • new GitHub CI Checks: makesure that one of them exists:
    • changes of CHANGELOG.md
    • label "no-need-update-changelog" on this PR
  • update PR template for the checklist with CHANGELOG

Related changes

  • Need to update chaos-mesh/website
  • Need to update Dashboard UI
  • Need to cheery-pick to release branches
    • release-2.1
    • release-2.0

Checklist

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

Side effects

  • Breaking backward compatibility

Release note

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 18, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Hexilee
  • iguoyr

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@STRRL STRRL force-pushed the must-have-changelog branch 2 times, most recently from 97169b1 to 7db1e90 Compare April 18, 2022 06:57
@STRRL STRRL added the no-need-update-changelog Skip CI check "Must Update CHANGELOG" for this PR label Apr 18, 2022
@STRRL STRRL force-pushed the must-have-changelog branch 2 times, most recently from 7a88c60 to 4ea568f Compare April 18, 2022 07:06
Signed-off-by: STRRL <im@strrl.dev>
Signed-off-by: STRRL <im@strrl.dev>
Signed-off-by: STRRL <im@strrl.dev>
@STRRL STRRL removed the no-need-update-changelog Skip CI check "Must Update CHANGELOG" for this PR label Apr 18, 2022
Signed-off-by: STRRL <im@strrl.dev>
@STRRL STRRL added the no-need-update-changelog Skip CI check "Must Update CHANGELOG" for this PR label Apr 18, 2022
@STRRL STRRL marked this pull request as ready for review April 18, 2022 07:18
@STRRL
Copy link
Member Author

STRRL commented Apr 18, 2022

PTAL

/cc @iguoyr @YangKeao @Hexilee

@STRRL STRRL removed the no-need-update-changelog Skip CI check "Must Update CHANGELOG" for this PR label Apr 18, 2022
Signed-off-by: STRRL <im@strrl.dev>
Copy link
Member

@Hexilee Hexilee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

.github/workflows/must_update_changelog.yml Outdated Show resolved Hide resolved
Copy link
Member

@iguoyr iguoyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@STRRL
Copy link
Member Author

STRRL commented Apr 20, 2022

/hold

Signed-off-by: STRRL <im@strrl.dev>
Copy link
Member

@Hexilee Hexilee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@STRRL
Copy link
Member Author

STRRL commented Apr 20, 2022

/hold cancel

@STRRL
Copy link
Member Author

STRRL commented Apr 20, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ee850cd

@ti-srebot
Copy link
Contributor

cherry pick to release-2.1 failed

@ti-srebot
Copy link
Contributor

cherry pick to release-2.0 failed

STRRL added a commit to STRRL/chaos-mesh that referenced this pull request Apr 25, 2022
* ci: new check for changelog

Signed-off-by: STRRL <im@strrl.dev>

* chore: update changelog

Signed-off-by: STRRL <im@strrl.dev>

* chore: update pr template

Signed-off-by: STRRL <im@strrl.dev>

* chore: rename file

Signed-off-by: STRRL <im@strrl.dev>

* chore: remove colon

Signed-off-by: STRRL <im@strrl.dev>

* refactor: use job level env

Signed-off-by: STRRL <im@strrl.dev>
@STRRL STRRL mentioned this pull request Apr 25, 2022
11 tasks
@STRRL
Copy link
Member Author

STRRL commented Apr 25, 2022

cherry pick to release-2.1 failed

Manually cherry-pick: #3181

STRRL added a commit to STRRL/chaos-mesh that referenced this pull request Apr 25, 2022
* ci: new check for changelog

Signed-off-by: STRRL <im@strrl.dev>

* chore: update changelog

Signed-off-by: STRRL <im@strrl.dev>

* chore: update pr template

Signed-off-by: STRRL <im@strrl.dev>

* chore: rename file

Signed-off-by: STRRL <im@strrl.dev>

* chore: remove colon

Signed-off-by: STRRL <im@strrl.dev>

* refactor: use job level env

Signed-off-by: STRRL <im@strrl.dev>
@STRRL STRRL mentioned this pull request Apr 25, 2022
11 tasks
@STRRL
Copy link
Member Author

STRRL commented Apr 25, 2022

cherry pick to release-2.0 failed

Manually cherry-pick :#3182

ti-chi-bot added a commit that referenced this pull request Apr 26, 2022
* ci: new check for changelog (#3148)

* ci: new check for changelog

Signed-off-by: STRRL <im@strrl.dev>

* chore: update changelog

Signed-off-by: STRRL <im@strrl.dev>

* chore: update pr template

Signed-off-by: STRRL <im@strrl.dev>

* chore: rename file

Signed-off-by: STRRL <im@strrl.dev>

* chore: remove colon

Signed-off-by: STRRL <im@strrl.dev>

* refactor: use job level env

Signed-off-by: STRRL <im@strrl.dev>

* chore: update PR links

Signed-off-by: STRRL <im@strrl.dev>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit that referenced this pull request Apr 26, 2022
* ci: new check for changelog (#3148)

* ci: new check for changelog

Signed-off-by: STRRL <im@strrl.dev>

* chore: update changelog

Signed-off-by: STRRL <im@strrl.dev>

* chore: update pr template

Signed-off-by: STRRL <im@strrl.dev>

* chore: rename file

Signed-off-by: STRRL <im@strrl.dev>

* chore: remove colon

Signed-off-by: STRRL <im@strrl.dev>

* refactor: use job level env

Signed-off-by: STRRL <im@strrl.dev>

* chore: update changelog

Signed-off-by: STRRL <im@strrl.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure the pull request update the CHANGELOG.md
5 participants