Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: ignore internal link/anchor #3162

Merged
merged 1 commit into from
Apr 20, 2022
Merged

ci: ignore internal link/anchor #3162

merged 1 commit into from
Apr 20, 2022

Conversation

STRRL
Copy link
Member

@STRRL STRRL commented Apr 20, 2022

Signed-off-by: STRRL im@strrl.dev

What problem does this PR solve?

What's changed and how it works?

  • update ignore patterns, ignore links (anchor) start with #

as gaurav-nelson/github-action-markdown-link-check#129 (comment) says, a available solution is to disable checks on anchors. So I set a ignore pattern for that

Related changes

  • Need to update chaos-mesh/website
  • Need to update Dashboard UI
  • Need to cheery-pick to release branches
    • release-2.1
    • release-2.0

Checklist

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

I tested it with act on my local machine. :)

Side effects

  • Breaking backward compatibility

Release note 

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

@STRRL
ci: ignore internal link/anchor
b2f08fa 
Signed-off-by: STRRL <im@strrl.dev>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 20, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • fewdan
  • g1eny0ung

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@STRRL
Copy link
Member Author

STRRL commented Apr 20, 2022

PTAL

/cc @chaos-mesh/committers @chaos-mesh/maintainers

@ti-chi-bot ti-chi-bot requested review from a team April 20, 2022 07:15
fewdan
fewdan approved these changes Apr 20, 2022
View reviewed changes
Copy link
Member

@fewdan fewdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

g1eny0ung
g1eny0ung approved these changes Apr 20, 2022
View reviewed changes
Copy link
Member

@g1eny0ung g1eny0ung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@g1eny0ung g1eny0ung merged commit d7bc4f7 into chaos-mesh:master Apr 20, 2022
@ti-srebot ti-srebot mentioned this pull request Apr 20, 2022
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-2.1 in PR #3163

ti-chi-bot pushed a commit that referenced this pull request Apr 20, 2022
@ti-srebot @STRRL
ci: ignore internal link/anchor (#3162) (#3163)
f4c52e8 
Signed-off-by: STRRL <im@strrl.dev>

Co-authored-by: STRRL <im@strrl.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g1eny0ung g1eny0ung g1eny0ung approved these changes

@fewdan fewdan fewdan approved these changes

@AsterNighT AsterNighT Awaiting requested review from AsterNighT

@Yiyiyimu Yiyiyimu Awaiting requested review from Yiyiyimu

Assignees
No one assigned
Labels
needs-cherry-pick-release-2.1 size/XS status/LGT2 type/bug-fix A bug needs to be fixed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed CI: markdown link check
5 participants
@STRRL @ti-chi-bot @ti-srebot @g1eny0ung @fewdan