-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run ci and integration test task on arm #3177
run ci and integration test task on arm #3177
Conversation
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
faea049
to
18681a5
Compare
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Codecov Report
@@ Coverage Diff @@
## master #3177 +/- ##
==========================================
+ Coverage 40.81% 40.95% +0.13%
==========================================
Files 164 164
Lines 13811 13811
==========================================
+ Hits 5637 5656 +19
+ Misses 7743 7728 -15
+ Partials 431 427 -4
Continue to review full report at Codecov.
|
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
c4d928e
to
8926277
Compare
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
@YangKeao: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…on-arm Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
…on-arm Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
9051773
to
4268046
Compare
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Some problems found in this PR is also recorded in #3173 |
- name: Magic Kind DNS Fix | ||
if: ${{ matrix.arch == 'arm64' }} | ||
run: | | ||
docker exec chart-testing-control-plane /bin/bash -c "sed -e 's/nameserver \(.*\)/nameserver 8.8.8.8/g' /etc/resolv.conf > /etc/resolv.conf.sed" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The network problem in kind is all about DNS.
kind
has some magic scripts to fix the DNS loop in coredns when running inside a docker and the DNS server is a local address, see https://github.com/kubernetes-sigs/kind/blob/main/images/base/files/usr/local/bin/entrypoint#L375, and so does minikube
. The awful thing is that: these scripts run, iptables rules are also applied successfully, but the DNS just don't work.
I have entered the environment manually, and dig/nslookup/tcpdump/... the DNS request with a lot of tools, but both the redirection source/target doesn't respond the DNS request. To further understand the problem, we could trace with the iptables, enable debug log of dockerd... It will take a lot more time to find the root, so I choose a much simpler way to solve: replace the dns server to 8.8.8.8 ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
LGTM |
@YangKeao Remember to update the configuration of ti-chi-bot before merging this pr. https://github.com/ti-community-infra/configs/blob/main/prow/config/config.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 4b36baa
|
Signed-off-by: YangKeao yangkeao@chunibyo.icu
What problem does this PR solve?
Run ci workflow on arm