Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run ci and integration test task on arm #3177

Merged
merged 37 commits into from
May 25, 2022

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Apr 22, 2022

Signed-off-by: YangKeao yangkeao@chunibyo.icu

What problem does this PR solve?

Run ci workflow on arm

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 22, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • WangXiangUSTC
  • cwen0

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@YangKeao YangKeao mentioned this pull request Apr 22, 2022
10 tasks
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #3177 (4b36baa) into master (c743fc2) will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3177      +/-   ##
==========================================
+ Coverage   40.81%   40.95%   +0.13%     
==========================================
  Files         164      164              
  Lines       13811    13811              
==========================================
+ Hits         5637     5656      +19     
+ Misses       7743     7728      -15     
+ Partials      431      427       -4     
Impacted Files Coverage Δ
.../workflow/controllers/workflow_entry_reconciler.go 49.18% <0.00%> (+2.16%) ⬆️
pkg/workflow/controllers/chaos_node_reconciler.go 61.31% <0.00%> (+3.15%) ⬆️
controllers/statuscheck/controller.go 84.14% <0.00%> (+4.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c743fc2...4b36baa. Read the comment docs.

@YangKeao YangKeao added the rebuild-dev-env-image rebuild dev-env image in this PR label Apr 22, 2022
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@YangKeao YangKeao changed the title add integration test and ci on arm run ci task on arm Apr 22, 2022
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@ti-chi-bot ti-chi-bot added size/M and removed size/S labels Apr 22, 2022
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@YangKeao YangKeao changed the title run ci task on arm run ci and integration test task on arm Apr 22, 2022
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

.github/workflows/integration_test.yml Show resolved Hide resolved
@ti-chi-bot
Copy link
Member

@YangKeao: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
…on-arm

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
…on-arm

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@ti-chi-bot ti-chi-bot added size/L and removed size/M labels May 17, 2022
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@YangKeao
Copy link
Member Author

Some problems found in this PR is also recorded in #3173

- name: Magic Kind DNS Fix
if: ${{ matrix.arch == 'arm64' }}
run: |
docker exec chart-testing-control-plane /bin/bash -c "sed -e 's/nameserver \(.*\)/nameserver 8.8.8.8/g' /etc/resolv.conf > /etc/resolv.conf.sed"
Copy link
Member Author

@YangKeao YangKeao May 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The network problem in kind is all about DNS.

kind has some magic scripts to fix the DNS loop in coredns when running inside a docker and the DNS server is a local address, see https://github.com/kubernetes-sigs/kind/blob/main/images/base/files/usr/local/bin/entrypoint#L375, and so does minikube. The awful thing is that: these scripts run, iptables rules are also applied successfully, but the DNS just don't work.

I have entered the environment manually, and dig/nslookup/tcpdump/... the DNS request with a lot of tools, but both the redirection source/target doesn't respond the DNS request. To further understand the problem, we could trace with the iptables, enable debug log of dockerd... It will take a lot more time to find the root, so I choose a much simpler way to solve: replace the dns server to 8.8.8.8 ...

@STRRL STRRL self-requested a review May 17, 2022 16:39
@YangKeao YangKeao requested a review from a team May 19, 2022 07:23
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

test/integration_test/run.sh Outdated Show resolved Hide resolved
test/integration_test/run.sh Show resolved Hide resolved
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@WangXiangUSTC
Copy link
Contributor

LGTM

@cwen0
Copy link
Member

cwen0 commented May 24, 2022

@YangKeao Remember to update the configuration of ti-chi-bot before merging this pr. https://github.com/ti-community-infra/configs/blob/main/prow/config/config.yaml

Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member

cwen0 commented May 24, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4b36baa

@ti-chi-bot ti-chi-bot merged commit b65fd22 into chaos-mesh:master May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants