Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customised logger with io.writer #3197

Merged
merged 13 commits into from
May 23, 2022
Merged

Customised logger with io.writer #3197

merged 13 commits into from
May 23, 2022

Conversation

basit9958
Copy link
Contributor

@basit9958 basit9958 commented Apr 26, 2022 •
edited

What problem does this PR solve?

Close #2892

What's changed and how it works?

Related changes

  • Need to update chaos-mesh/website
  • Need to update Dashboard UI
  • Need to cheery-pick to release branches
    • release-2.1
    • release-2.0

Checklist

CHANGELOG

  • I have updated the CHANGELOG.md
  • I have labeled this PR with "no-need-update-changelog"

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

Side effects

  • Breaking backward compatibility

Release note 

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 26, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • STRRL
  • cwen0

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@basit9958
Copy link
Contributor Author

cc @STRRL

@STRRL
Copy link
Member

STRRL commented Apr 27, 2022

Hi @basit9958 , please execute make check to fix the CI Check.

@STRRL STRRL added the no-need-update-changelog Skip CI check "Must Update CHANGELOG" for this PR label Apr 27, 2022
@basit9958 basit9958 force-pushed the customised-logger-with-io.writer branch from 8d5856c to 8bf5e16 Compare April 27, 2022 16:16
@basit9958 basit9958 force-pushed the customised-logger-with-io.writer branch from 8bf5e16 to 550dca4 Compare May 2, 2022 00:39
@codecov
Copy link

codecov bot commented May 2, 2022 •
edited

Codecov Report

Merging #3197 (fddec81) into master (2eca5c1) will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3197      +/-   ##
==========================================
+ Coverage   40.87%   41.07%   +0.19%     
==========================================
  Files         164      164              
  Lines       13798    13798              
==========================================
+ Hits         5640     5667      +27     
+ Misses       7732     7709      -23     
+ Partials      426      422       -4
Impacted Files Coverage Δ
pkg/workflow/controllers/task_reconciler.go 6.70% <0.00%> (+0.80%) ⬆️
pkg/workflow/controllers/statuscheck_reconciler.go 9.09% <0.00%> (+1.51%) ⬆️
pkg/workflow/controllers/utils.go 87.59% <0.00%> (+1.55%) ⬆️
pkg/workflow/controllers/serial_node_reconciler.go 61.13% <0.00%> (+1.55%) ⬆️
...g/workflow/controllers/parallel_node_reconciler.go 62.02% <0.00%> (+1.89%) ⬆️
.../workflow/controllers/workflow_entry_reconciler.go 54.05% <0.00%> (+7.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2eca5c1...fddec81. Read the comment docs.

g1eny0ung and others added 4 commits May 3, 2022 22:25
@g1eny0ung @ti-chi-bot @basit9958
refactor(ui): rewrite form fields (chaos-mesh#3107)
1a4b87b 
* refactor: rewrite form fields

1. The theme palette has been updated because of the new form fields.
2. Extracts old `Scope` component to `components/` for next use.

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* fix: license checker

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* chore: address comments

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Signed-off-by: Basit Hasan <hasanbasit13@gmail.com>
@basit9958
New logger with custom io.writer
8a09144 
Signed-off-by: Basit Hasan <hasanbasit13@gmail.com>
@basit9958
Revert "refactor(ui): rewrite form fields (chaos-mesh#3107)"
a81b23c 
This reverts commit aa096fe.

Signed-off-by: Basit Hasan <hasanbasit13@gmail.com>
@basit9958
changes in file github.com/onsi/ginkgo
1d18904 
Signed-off-by: Basit Hasan <hasanbasit13@gmail.com>
@basit9958 basit9958 force-pushed the customised-logger-with-io.writer branch from 6ae13f1 to 1d18904 Compare May 3, 2022 16:56
@basit9958
Added import files
1dbcc94 
Signed-off-by: Basit Hasan <hasanbasit13@gmail.com>
@ti-chi-bot ti-chi-bot added size/M and removed size/S labels May 3, 2022
@basit9958 basit9958 force-pushed the customised-logger-with-io.writer branch from c9e8cf2 to b49d505 Compare May 4, 2022 13:35
@basit9958
changed gingko.GingkoWriter to GingkoWriter
168b36e 
Signed-off-by: Basit Hasan <hasanbasit13@gmail.com>
@ti-chi-bot ti-chi-bot added size/S and removed size/M labels May 5, 2022
@basit9958
make check
081728d 
Signed-off-by: Basit Hasan <hasanbasit13@gmail.com>
@basit9958
Copy link
Contributor Author

cc @STRRL

STRRL
STRRL reviewed May 7, 2022
View reviewed changes
pkg/log/zap.go Outdated Show resolved Hide resolved
@basit9958
removing configurations
2e5b32a 
Signed-off-by: Basit Hasan <hasanbasit13@gmail.com>
@basit9958
enabling caller
bd4c3a1 
Signed-off-by: Basit Hasan <hasanbasit13@gmail.com>
@basit9958
Added comments for config
3b1429b 
Signed-off-by: Basit Hasan <hasanbasit13@gmail.com>
@ti-chi-bot ti-chi-bot added size/M and removed size/S labels May 7, 2022
@basit9958
make check
f549caf 
Signed-off-by: Basit Hasan <hasanbasit13@gmail.com>
STRRL
STRRL approved these changes May 7, 2022
View reviewed changes
Copy link
Member

@STRRL STRRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cwen0
cwen0 approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member

cwen0 commented May 23, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f549caf

@ti-chi-bot ti-chi-bot merged commit 61532d2 into chaos-mesh:master May 23, 2022
@basit9958 basit9958 deleted the customised-logger-with-io.writer branch May 23, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonatype-lift sonatype-lift[bot] sonatype-lift left review comments

@STRRL STRRL STRRL approved these changes

@cwen0 cwen0 cwen0 approved these changes

@YangKeao YangKeao Awaiting requested review from YangKeao

Assignees
No one assigned
Labels
contribution no-need-update-changelog Skip CI check "Must Update CHANGELOG" for this PR size/M status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refine logging in integration tests, use customized logger with GinkgoWriter
5 participants
@basit9958 @ti-chi-bot @STRRL @cwen0 @g1eny0ung