Fix for make check does not respect the env-images.yaml

[DaivikDave]

Signed-off-by: Daivik daivikdave229@gmail.com

What problem does this PR solve?

#3210

What's changed and how it works?

IMAGE_DEV_ENV_TAG and IMAGE_DEV_ENV_TAG were not accessible in build/build_images.py. It resulted in it taking the default value defined by export IMAGE_TAG ?= latest

Related changes

• Need to update chaos-mesh/website
• Need to update Dashboard UI
• Need to cheery-pick to release branches
  • release-2.1
  • release-2.0

Checklist

CHANGELOG

• I have updated the CHANGELOG.md
• I have labeled this PR with "no-need-update-changelog"

Tests

• Unit test
• E2E test
• No code
• Manual test (add steps below)

Side effects

• Breaking backward compatibility

Release note

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• STRRL
• YangKeao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[codecov]

Codecov Report

Merging #3216 (3da8fb0) into master (58227af) will decrease coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3216      +/-   ##
==========================================
- Coverage   41.26%   41.11%   -0.16%     
==========================================
  Files         165      165              
  Lines       13819    13819              
==========================================
- Hits         5703     5681      -22     
- Misses       7691     7707      +16     
- Partials      425      431       +6     

Impacted Files	Coverage Δ
pkg/workflow/controllers/abort_node_reconciler.go	15.11% <0.00%> (-3.49%)	⬇️
pkg/selector/generic/mode.go	25.64% <0.00%> (-2.57%)	⬇️
pkg/workflow/controllers/chaos_node_reconciler.go	55.87% <0.00%> (-2.30%)	⬇️
.../workflow/controllers/workflow_entry_reconciler.go	54.05% <0.00%> (-2.17%)	⬇️
...g/workflow/controllers/parallel_node_reconciler.go	60.12% <0.00%> (-1.90%)	⬇️
pkg/workflow/controllers/serial_node_reconciler.go	59.58% <0.00%> (-1.56%)	⬇️
pkg/workflow/controllers/task_reconciler.go	5.89% <0.00%> (-0.81%)	⬇️
.../workflow/controllers/abort_workflow_reconciler.go	57.14% <0.00%> (+8.16%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58227af...3da8fb0. Read the comment docs.

[STRRL]

Hi @DaivikDave! Thanks for your contribution!

Please update the CHANGELOG.md, rest LGTM!

after exporting enough of ENV, maybe BASIC_IMAGE_ENV could be removed in the future?

/cc @YangKeao

[DaivikDave]

Thanks @STRRL , Updated the changelog!

[STRRL]

Thanks @STRRL , Updated the changelog!

Hi @DaivikDave , you should update the section under Unreleased, not 2.2.0 :)

[STRRL]

Hi @DaivikDave, do you need some help? :)

[DaivikDave]

Hey @STRRL , I was unable to work on it due to some urgency. I'll get the changes pushed.

[DaivikDave]

Hey @STRRL , Sorry for the delay, I made the changes.

[STRRL]

LGTM!

[STRRL]

/cc @YangKeao @iguoyr

[YangKeao]

LGTM

BTW: export doesn't work for the shell command in the Makefile. It's a known but will not be fixed issue (of the GNU make) 😢 .

[STRRL]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 1ed522c

[ti-srebot]

cherry pick to release-2.1 failed

[ti-srebot]

cherry pick to release-2.2 failed