Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add CII best practices badge for Chaos Mesh #3260

Merged
merged 2 commits into from
May 12, 2022

Conversation

STRRL
Copy link
Member

@STRRL STRRL commented May 11, 2022

Signed-off-by: STRRL str_ruiling@outlook.com

What problem does this PR solve?

CII Best Practices

What's changed and how it works?

Related changes

  • Need to update chaos-mesh/website
  • Need to update Dashboard UI
  • Need to cheery-pick to release branches
    • release-2.1
    • release-2.0

Checklist

CHANGELOG

  • I have updated the CHANGELOG.md
  • I have labeled this PR with "no-need-update-changelog"

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

Side effects

  • Breaking backward compatibility

Release note

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

Signed-off-by: STRRL <str_ruiling@outlook.com>
@STRRL STRRL added the no-need-update-changelog Skip CI check "Must Update CHANGELOG" for this PR label May 11, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 11, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • YangKeao
  • dcalvin

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested review from cwen0 and YangKeao May 11, 2022 08:49
@STRRL
Copy link
Member Author

STRRL commented May 11, 2022

/cc @YangKeao @cwen0 @dcalvin

Signed-off-by: STRRL <str_ruiling@outlook.com>
@YangKeao
Copy link
Member

I wonder how these values are evaluated?

@STRRL
Copy link
Member Author

STRRL commented May 11, 2022

I wonder how these values are evaluated?

It should be updated MANUALLY. I could update it after login with GitHub.
image

But I am not sure how that platform resolves the permission.

Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dcalvin dcalvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@STRRL
Copy link
Member Author

STRRL commented May 12, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 559ad31

@ti-chi-bot ti-chi-bot merged commit 2df6e52 into chaos-mesh:master May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-need-update-changelog Skip CI check "Must Update CHANGELOG" for this PR size/XS status/can-merge status/LGT2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants