Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete unused webhook of PodHttpChaos #3291

Merged
merged 2 commits into from
May 25, 2022

Conversation

Hexilee
Copy link
Member

@Hexilee Hexilee commented May 24, 2022

Signed-off-by: xixi i@hexilee.me

What problem does this PR solve?

The webhook of PodHttpChaos is unused since v2.0.0.

What's changed and how it works?

Delete the api/v1alpha1/podhttpchaos_webhook.go.

Related changes

  • Need to update chaos-mesh/website
  • Need to update Dashboard UI
  • Need to cheery-pick to release branches
    • release-2.2
    • release-2.1

Checklist

CHANGELOG

  • I have updated the CHANGELOG.md
  • I have labeled this PR with "no-need-update-changelog"

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

Side effects

  • Breaking backward compatibility

Release note

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

Signed-off-by: xixi <i@hexilee.me>
@Hexilee Hexilee added the no-need-update-changelog Skip CI check "Must Update CHANGELOG" for this PR label May 24, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 24, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Andrewmatilde
  • YangKeao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Copy link
Member

@Andrewmatilde Andrewmatilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@Hexilee
Copy link
Member Author

Hexilee commented May 24, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0625c19

@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #3291 (49e0dee) into master (b65fd22) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3291      +/-   ##
==========================================
+ Coverage   40.82%   40.86%   +0.03%     
==========================================
  Files         164      163       -1     
  Lines       13811    13786      -25     
==========================================
- Hits         5638     5633       -5     
+ Misses       7742     7722      -20     
  Partials      431      431              
Impacted Files Coverage Δ
.../workflow/controllers/abort_workflow_reconciler.go 48.97% <0.00%> (-8.17%) ⬇️
pkg/workflow/controllers/deadline_reconciler.go 64.44% <0.00%> (-5.19%) ⬇️
pkg/selector/generic/mode.go 28.20% <0.00%> (+2.56%) ⬆️
controllers/statuscheck/controller.go 84.14% <0.00%> (+4.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b65fd22...49e0dee. Read the comment docs.

@cwen0
Copy link
Member

cwen0 commented May 24, 2022

/merge

@ti-chi-bot ti-chi-bot merged commit e522d9f into chaos-mesh:master May 25, 2022
@ti-srebot
Copy link
Contributor

cherry pick to release-2.0 failed

@ti-srebot
Copy link
Contributor

cherry pick to release-2.1 in PR #3295

@ti-srebot
Copy link
Contributor

cherry pick to release-2.2 in PR #3296

ti-chi-bot added a commit that referenced this pull request Jun 6, 2022
Signed-off-by: xixi <i@hexilee.me>

Co-authored-by: xixi <i@hexilee.me>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants