-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
delete unused webhook of PodHttpChaos #3291
Conversation
Signed-off-by: xixi <i@hexilee.me>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😄
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 0625c19
|
Codecov Report
@@ Coverage Diff @@
## master #3291 +/- ##
==========================================
+ Coverage 40.82% 40.86% +0.03%
==========================================
Files 164 163 -1
Lines 13811 13786 -25
==========================================
- Hits 5638 5633 -5
+ Misses 7742 7722 -20
Partials 431 431
Continue to review full report at Codecov.
|
/merge |
cherry pick to release-2.0 failed |
cherry pick to release-2.1 in PR #3295 |
cherry pick to release-2.2 in PR #3296 |
Signed-off-by: xixi i@hexilee.me
What problem does this PR solve?
The webhook of PodHttpChaos is unused since v2.0.0.
What's changed and how it works?
Delete the
api/v1alpha1/podhttpchaos_webhook.go
.Related changes
chaos-mesh/website
Dashboard UI
Checklist
CHANGELOG
CHANGELOG.md
Tests
Side effects
Release note
DCO
If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it: