Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-trigger ci 'must_update_changelog' when labels change #3300

Merged
merged 9 commits into from
May 30, 2022

Conversation

Hexilee
Copy link
Member

@Hexilee Hexilee commented May 25, 2022

Signed-off-by: xixi i@hexilee.me

What problem does this PR solve?

The result of CI must_update_changelog depends on the label "no-need-update-changelog", but it won't re-run when labels change. This PR resolved a part of #3301.

What's changed and how it works?

Related changes

  • Need to update chaos-mesh/website
  • Need to update Dashboard UI
  • Need to cheery-pick to release branches
    • release-2.2
    • release-2.1

Checklist

CHANGELOG

  • I have updated the CHANGELOG.md
  • I have labeled this PR with "no-need-update-changelog"

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

Side effects

  • Breaking backward compatibility

Release note

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 25, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • STRRL
  • YangKeao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested review from STRRL and yeya24 May 25, 2022 06:37
@Hexilee Hexilee added no-need-update-changelog Skip CI check "Must Update CHANGELOG" for this PR needs-cherry-pick-release-2.1 needs-cherry-pick-release-2.2 and removed no-need-update-changelog Skip CI check "Must Update CHANGELOG" for this PR labels May 25, 2022
Signed-off-by: xixi <i@hexilee.me>
Signed-off-by: xixi <i@hexilee.me>
@Hexilee
Copy link
Member Author

Hexilee commented May 25, 2022

/run-e2e-tests

Signed-off-by: xixi <i@hexilee.me>
Signed-off-by: xixi <i@hexilee.me>
@Hexilee Hexilee added no-need-update-changelog Skip CI check "Must Update CHANGELOG" for this PR and removed no-need-update-changelog Skip CI check "Must Update CHANGELOG" for this PR labels May 25, 2022
Signed-off-by: xixi <i@hexilee.me>
@ti-chi-bot ti-chi-bot added size/XS and removed size/S labels May 25, 2022
@Hexilee Hexilee changed the title re-trigger ci 'must_update_changelog' and 'e2e_test' when labels change re-trigger ci 'must_update_changelog' when labels change May 25, 2022
Copy link
Member

@STRRL STRRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@STRRL
Copy link
Member

STRRL commented May 27, 2022

/cc @Andrewmatilde @iguoyr @YangKeao @cwen0

PTAL ❤️

Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YangKeao
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c4116e2

@STRRL
Copy link
Member

STRRL commented May 27, 2022

/hold

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@STRRL
Copy link
Member

STRRL commented May 27, 2022

/hold cancel

It seems the GHA Workflow "Must Update CHANGELOG" are triggered multiple times:

Do not mind. I think this situation is caused by github itself.

@Hexilee
Copy link
Member Author

Hexilee commented May 29, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 27cd70a

@ti-chi-bot ti-chi-bot merged commit 38b41fc into chaos-mesh:master May 30, 2022
@ti-srebot
Copy link
Contributor

cherry pick to release-2.1 failed

@ti-srebot
Copy link
Contributor

cherry pick to release-2.2 failed

Hexilee added a commit to Hexilee/chaos-mesh that referenced this pull request May 31, 2022
…3300)

* re-trigger ci 'must_update_changelog' and 'e2e_test' when labels change

Signed-off-by: xixi <i@hexilee.me>

* update skip check for e2e_test

Signed-off-by: xixi <i@hexilee.me>

* delete unused steps

Signed-off-by: xixi <i@hexilee.me>

* fix e2e_test

Signed-off-by: xixi <i@hexilee.me>

* fix e2e_test again

Signed-off-by: xixi <i@hexilee.me>

* revoke e2e_test

Signed-off-by: xixi <i@hexilee.me>

* trigger ci

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

Co-authored-by: YangKeao <yangkeao@chunibyo.icu>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Hexilee added a commit to Hexilee/chaos-mesh that referenced this pull request May 31, 2022
…3300)

* re-trigger ci 'must_update_changelog' and 'e2e_test' when labels change

Signed-off-by: xixi <i@hexilee.me>

* update skip check for e2e_test

Signed-off-by: xixi <i@hexilee.me>

* delete unused steps

Signed-off-by: xixi <i@hexilee.me>

* fix e2e_test

Signed-off-by: xixi <i@hexilee.me>

* fix e2e_test again

Signed-off-by: xixi <i@hexilee.me>

* revoke e2e_test

Signed-off-by: xixi <i@hexilee.me>

* trigger ci

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

Co-authored-by: YangKeao <yangkeao@chunibyo.icu>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
ti-chi-bot added a commit that referenced this pull request May 31, 2022
… change (#3319)

* re-trigger ci 'must_update_changelog' and 'e2e_test' when labels change

Signed-off-by: xixi <i@hexilee.me>

* update skip check for e2e_test

Signed-off-by: xixi <i@hexilee.me>

* delete unused steps

Signed-off-by: xixi <i@hexilee.me>

* fix e2e_test

Signed-off-by: xixi <i@hexilee.me>

* fix e2e_test again

Signed-off-by: xixi <i@hexilee.me>

* revoke e2e_test

Signed-off-by: xixi <i@hexilee.me>

* trigger ci

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

Co-authored-by: YangKeao <yangkeao@chunibyo.icu>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>

Co-authored-by: YangKeao <yangkeao@chunibyo.icu>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
ti-chi-bot added a commit that referenced this pull request May 31, 2022
… change (#3318)

* re-trigger ci 'must_update_changelog' and 'e2e_test' when labels change

Signed-off-by: xixi <i@hexilee.me>

* update skip check for e2e_test

Signed-off-by: xixi <i@hexilee.me>

* delete unused steps

Signed-off-by: xixi <i@hexilee.me>

* fix e2e_test

Signed-off-by: xixi <i@hexilee.me>

* fix e2e_test again

Signed-off-by: xixi <i@hexilee.me>

* revoke e2e_test

Signed-off-by: xixi <i@hexilee.me>

* trigger ci

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

Co-authored-by: YangKeao <yangkeao@chunibyo.icu>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>

Co-authored-by: YangKeao <yangkeao@chunibyo.icu>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants