-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-trigger ci 'must_update_changelog' when labels change #3300
Conversation
Signed-off-by: xixi <i@hexilee.me>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: xixi <i@hexilee.me>
Signed-off-by: xixi <i@hexilee.me>
/run-e2e-tests |
Signed-off-by: xixi <i@hexilee.me>
Signed-off-by: xixi <i@hexilee.me>
Signed-off-by: xixi <i@hexilee.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/cc @Andrewmatilde @iguoyr @YangKeao @cwen0 PTAL ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: c4116e2
|
/hold |
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
84b4007
to
27cd70a
Compare
/hold cancel
Do not mind. I think this situation is caused by github itself. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 27cd70a
|
cherry pick to release-2.1 failed |
cherry pick to release-2.2 failed |
…3300) * re-trigger ci 'must_update_changelog' and 'e2e_test' when labels change Signed-off-by: xixi <i@hexilee.me> * update skip check for e2e_test Signed-off-by: xixi <i@hexilee.me> * delete unused steps Signed-off-by: xixi <i@hexilee.me> * fix e2e_test Signed-off-by: xixi <i@hexilee.me> * fix e2e_test again Signed-off-by: xixi <i@hexilee.me> * revoke e2e_test Signed-off-by: xixi <i@hexilee.me> * trigger ci Signed-off-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
…3300) * re-trigger ci 'must_update_changelog' and 'e2e_test' when labels change Signed-off-by: xixi <i@hexilee.me> * update skip check for e2e_test Signed-off-by: xixi <i@hexilee.me> * delete unused steps Signed-off-by: xixi <i@hexilee.me> * fix e2e_test Signed-off-by: xixi <i@hexilee.me> * fix e2e_test again Signed-off-by: xixi <i@hexilee.me> * revoke e2e_test Signed-off-by: xixi <i@hexilee.me> * trigger ci Signed-off-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
… change (#3319) * re-trigger ci 'must_update_changelog' and 'e2e_test' when labels change Signed-off-by: xixi <i@hexilee.me> * update skip check for e2e_test Signed-off-by: xixi <i@hexilee.me> * delete unused steps Signed-off-by: xixi <i@hexilee.me> * fix e2e_test Signed-off-by: xixi <i@hexilee.me> * fix e2e_test again Signed-off-by: xixi <i@hexilee.me> * revoke e2e_test Signed-off-by: xixi <i@hexilee.me> * trigger ci Signed-off-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Co-authored-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
… change (#3318) * re-trigger ci 'must_update_changelog' and 'e2e_test' when labels change Signed-off-by: xixi <i@hexilee.me> * update skip check for e2e_test Signed-off-by: xixi <i@hexilee.me> * delete unused steps Signed-off-by: xixi <i@hexilee.me> * fix e2e_test Signed-off-by: xixi <i@hexilee.me> * fix e2e_test again Signed-off-by: xixi <i@hexilee.me> * revoke e2e_test Signed-off-by: xixi <i@hexilee.me> * trigger ci Signed-off-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Co-authored-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Signed-off-by: xixi i@hexilee.me
What problem does this PR solve?
The result of CI
must_update_changelog
depends on the label "no-need-update-changelog", but it won't re-run when labels change. This PR resolved a part of #3301.What's changed and how it works?
Related changes
chaos-mesh/website
Dashboard UI
Checklist
CHANGELOG
CHANGELOG.md
Tests
Side effects
Release note
DCO
If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it: