-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove not used Clientset in cmd/chaos-controller-manager/main.go #3334
Remove not used Clientset in cmd/chaos-controller-manager/main.go #3334
Conversation
Signed-off-by: z1cheng <imchench@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: z1cheng <imchench@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #3334 +/- ##
==========================================
+ Coverage 40.99% 41.04% +0.05%
==========================================
Files 165 165
Lines 13819 13819
==========================================
+ Hits 5665 5672 +7
+ Misses 7722 7714 -8
- Partials 432 433 +1
Continue to review full report at Codecov.
|
Welcome @z1cheng ! Thanks for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 1ccf6ba
|
Signed-off-by: z1cheng imchench@gmail.com
What problem does this PR solve?
Close #3331
What's changed and how it works?
Related changes
chaos-mesh/website
Dashboard UI
Checklist
CHANGELOG
CHANGELOG.md
Tests
Side effects
Release note
DCO
If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it: