Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove not used Clientset in cmd/chaos-controller-manager/main.go #3334

Merged
merged 3 commits into from
Jun 8, 2022
Merged

Remove not used Clientset in cmd/chaos-controller-manager/main.go #3334

merged 3 commits into from
Jun 8, 2022

Conversation

z1cheng
Copy link
Contributor

@z1cheng z1cheng commented Jun 7, 2022

Signed-off-by: z1cheng imchench@gmail.com

What problem does this PR solve?

Close #3331

What's changed and how it works?

Related changes

  • Need to update chaos-mesh/website
  • Need to update Dashboard UI
  • Need to cheery-pick to release branches
    • release-2.2
    • release-2.1

Checklist

CHANGELOG

  • I have updated the CHANGELOG.md
  • I have labeled this PR with "no-need-update-changelog"

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

Side effects

  • Breaking backward compatibility

Release note

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

Signed-off-by: z1cheng <imchench@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 7, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • STRRL
  • iguoyr

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: z1cheng <imchench@gmail.com>
@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #3334 (4ab8f7b) into master (5184d78) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3334      +/-   ##
==========================================
+ Coverage   40.99%   41.04%   +0.05%     
==========================================
  Files         165      165              
  Lines       13819    13819              
==========================================
+ Hits         5665     5672       +7     
+ Misses       7722     7714       -8     
- Partials      432      433       +1     
Impacted Files Coverage Δ
controllers/statuscheck/controller.go 79.26% <0.00%> (-4.88%) ⬇️
pkg/selector/generic/mode.go 28.20% <0.00%> (+2.56%) ⬆️
.../workflow/controllers/workflow_entry_reconciler.go 54.05% <0.00%> (+4.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89e4cb1...4ab8f7b. Read the comment docs.

@STRRL
Copy link
Member

STRRL commented Jun 8, 2022

Welcome @z1cheng ! Thanks for your contribution!

Copy link
Member

@STRRL STRRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@STRRL STRRL requested review from a team June 8, 2022 07:59
Copy link
Member

@iguoyr iguoyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iguoyr
Copy link
Member

iguoyr commented Jun 8, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1ccf6ba

@ti-chi-bot ti-chi-bot merged commit 516e550 into chaos-mesh:master Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: remove not used Clientset *kubernetes.Clientset
4 participants