Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove not used globalCacheReader #3343

Merged
merged 6 commits into from
Jun 21, 2022
Merged

remove not used globalCacheReader #3343

merged 6 commits into from
Jun 21, 2022

Conversation

nioshield
Copy link
Contributor

Signed-off-by: nio nioshield@gmail.com

What problem does this PR solve?

Close #3332

What's changed and how it works?

Related changes

  • Need to update chaos-mesh/website
  • Need to update Dashboard UI
  • Need to cheery-pick to release branches
    • release-2.2
    • release-2.1

Checklist

CHANGELOG

  • I have updated the CHANGELOG.md
  • I have labeled this PR with "no-need-update-changelog"

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

Side effects

  • Breaking backward compatibility

Release note

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

Signed-off-by: nio <nioshield@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 8, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • STRRL
  • YangKeao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

Welcome @nioshield!

It looks like this is your first PR to chaos-mesh/chaos-mesh 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to chaos-mesh/chaos-mesh. 😃

Signed-off-by: nio <nioshield@gmail.com>
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: nio <nioshield@gmail.com>
@STRRL
Copy link
Member

STRRL commented Jun 9, 2022

Welcome @nioshield , thanks for your contribution!

@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #3343 (3b43e40) into master (68b0b7b) will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3343      +/-   ##
==========================================
+ Coverage   41.09%   41.18%   +0.09%     
==========================================
  Files         165      165              
  Lines       13853    13849       -4     
==========================================
+ Hits         5693     5704      +11     
+ Misses       7726     7711      -15     
  Partials      434      434              
Impacted Files Coverage Δ
...md/chaos-controller-manager/provider/controller.go 40.70% <ø> (+1.39%) ⬆️
pkg/workflow/controllers/chaos_node_reconciler.go 58.16% <0.00%> (-3.16%) ⬇️
api/v1alpha1/zz_generated.chaosmesh.go 57.04% <0.00%> (-0.32%) ⬇️
pkg/selector/generic/mode.go 28.20% <0.00%> (+2.56%) ⬆️
pkg/workflow/controllers/deadline_reconciler.go 69.62% <0.00%> (+5.18%) ⬆️
.../workflow/controllers/workflow_entry_reconciler.go 56.21% <0.00%> (+9.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68b0b7b...3b43e40. Read the comment docs.

@nioshield
Copy link
Contributor Author

How do I fix IOChaos errors in merge check? @STRRL
😟😟

@STRRL
Copy link
Member

STRRL commented Jun 21, 2022

How do I fix IOChaos errors in merge check? @STRRL worriedworried

don't worry, the e2e tests are flaky, I would retry it;

Copy link
Member

@STRRL STRRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@STRRL
Copy link
Member

STRRL commented Jun 21, 2022

/cc @YangKeao

1 similar comment
@STRRL
Copy link
Member

STRRL commented Jun 21, 2022

/cc @YangKeao

Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YangKeao
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d7c4b5d

@ti-chi-bot
Copy link
Member

@nioshield: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@STRRL
Copy link
Member

STRRL commented Jun 21, 2022

/cc @YangKeao

It seems taichi bot does not work as expected, a little weird. 🤔🤔

@wuhuizuo
Copy link

/cc wuhuizuo

@ti-chi-bot
Copy link
Member

@wuhuizuo: GitHub didn't allow me to request PR reviews from the following users: wuhuizuo.

Note that only chaos-mesh members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc wuhuizuo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot merged commit aef6f9a into chaos-mesh:master Jun 21, 2022
stephen-harris pushed a commit to stephen-harris/chaos-mesh that referenced this pull request Jun 23, 2022
* remove not used globalCacheReader

Signed-off-by: nio <nioshield@gmail.com>

* remove not used globalCacheReader

Signed-off-by: nio <nioshield@gmail.com>

* fix changlog error

Signed-off-by: nio <nioshield@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Signed-off-by: Stephen Harris <stephen.harris1@kaluza.com>
STRRL pushed a commit to Garima-Negi/chaos-mesh that referenced this pull request Sep 13, 2022
* remove not used globalCacheReader

Signed-off-by: nio <nioshield@gmail.com>

* remove not used globalCacheReader

Signed-off-by: nio <nioshield@gmail.com>

* fix changlog error

Signed-off-by: nio <nioshield@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Signed-off-by: STRRL <im@strrl.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: remove not used globalCacheReader
6 participants