-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove not used globalCacheReader #3343
Conversation
Signed-off-by: nio <nioshield@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Welcome @nioshield! |
Signed-off-by: nio <nioshield@gmail.com>
Signed-off-by: nio <nioshield@gmail.com>
Welcome @nioshield , thanks for your contribution! |
Codecov Report
@@ Coverage Diff @@
## master #3343 +/- ##
==========================================
+ Coverage 41.09% 41.18% +0.09%
==========================================
Files 165 165
Lines 13853 13849 -4
==========================================
+ Hits 5693 5704 +11
+ Misses 7726 7711 -15
Partials 434 434
Continue to review full report at Codecov.
|
How do I fix IOChaos errors in merge check? @STRRL |
don't worry, the e2e tests are flaky, I would retry it; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/cc @YangKeao |
1 similar comment
/cc @YangKeao |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: d7c4b5d
|
@nioshield: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
It seems taichi bot does not work as expected, a little weird. 🤔🤔 |
/cc wuhuizuo |
@wuhuizuo: GitHub didn't allow me to request PR reviews from the following users: wuhuizuo. Note that only chaos-mesh members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
* remove not used globalCacheReader Signed-off-by: nio <nioshield@gmail.com> * remove not used globalCacheReader Signed-off-by: nio <nioshield@gmail.com> * fix changlog error Signed-off-by: nio <nioshield@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Signed-off-by: Stephen Harris <stephen.harris1@kaluza.com>
* remove not used globalCacheReader Signed-off-by: nio <nioshield@gmail.com> * remove not used globalCacheReader Signed-off-by: nio <nioshield@gmail.com> * fix changlog error Signed-off-by: nio <nioshield@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Signed-off-by: STRRL <im@strrl.dev>
Signed-off-by: nio nioshield@gmail.com
What problem does this PR solve?
Close #3332
What's changed and how it works?
Related changes
chaos-mesh/website
Dashboard UI
Checklist
CHANGELOG
CHANGELOG.md
Tests
Side effects
Release note
DCO
If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it: