Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renamed all occurances of chaos testing to chaos-mesh #3353

Merged

Conversation

afterlook
Copy link
Contributor

@afterlook afterlook commented Jun 11, 2022

What problem does this PR solve?

Close #2818

What's changed and how it works?

Related changes

  • Need to update chaos-mesh/website
  • Need to update Dashboard UI
  • Need to cheery-pick to release branches
    • release-2.2
    • release-2.1

Checklist

CHANGELOG

  • I have updated the CHANGELOG.md
  • I have labeled this PR with "no-need-update-changelog"

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

Side effects

  • Breaking backward compatibility

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 11, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • STRRL
  • xlgao-zju

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

Welcome @krystian-kulgawczuk!

It looks like this is your first PR to chaos-mesh/chaos-mesh 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to chaos-mesh/chaos-mesh. 😃

Signed-off-by: kkulgawczuk <29754364+krystian-kulgawczuk@users.noreply.github.com>
Signed-off-by: kkulgawczuk <29754364+krystian-kulgawczuk@users.noreply.github.com>
@afterlook afterlook force-pushed the refactor/change-global-namespace branch from c95fcd3 to 1d85073 Compare June 11, 2022 21:14
@afterlook
Copy link
Contributor Author

/cc @STRRL

@ti-chi-bot ti-chi-bot requested a review from STRRL June 11, 2022 21:18
@STRRL
Copy link
Member

STRRL commented Jun 12, 2022

Welcome @krystian-kulgawczuk !

@codecov
Copy link

codecov bot commented Jun 12, 2022

Codecov Report

Merging #3353 (548ccb7) into master (3e43c60) will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3353      +/-   ##
==========================================
+ Coverage   41.08%   41.18%   +0.10%     
==========================================
  Files         165      165              
  Lines       13853    13853              
==========================================
+ Hits         5691     5705      +14     
+ Misses       7729     7715      -14     
  Partials      433      433              
Impacted Files Coverage Δ
pkg/workflow/controllers/abort_node_reconciler.go 15.11% <0.00%> (-3.49%) ⬇️
pkg/workflow/controllers/statuscheck_reconciler.go 7.57% <0.00%> (-1.52%) ⬇️
pkg/workflow/controllers/task_reconciler.go 5.89% <0.00%> (-0.81%) ⬇️
pkg/selector/generic/mode.go 28.20% <0.00%> (+2.56%) ⬆️
.../workflow/controllers/abort_workflow_reconciler.go 57.14% <0.00%> (+8.16%) ⬆️
.../workflow/controllers/workflow_entry_reconciler.go 56.21% <0.00%> (+9.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e43c60...548ccb7. Read the comment docs.

Signed-off-by: kkulgawczuk <29754364+krystian-kulgawczuk@users.noreply.github.com>
@afterlook
Copy link
Contributor Author

Switching to new IDE and replace plugin didn't include hidden dirs... Fixed!

@afterlook
Copy link
Contributor Author

@STRRL Could you please take a look and help me figure out why the tests are failing? I noticed that on previous ci go test it passed and now it failed, but I don't see how I could've broken it. Can i trust these tests? :)

@g1eny0ung
Copy link
Member

@krystian-kulgawczuk I tested this locally, and it's probably because .editorconfig formatted the snap file automatically.

Run yarn workspace @ui/mui-extends test -u under the ui to update snapshots again can solve this problem.

Signed-off-by: STRRL <im@strrl.dev>
@STRRL
Copy link
Member

STRRL commented Jun 15, 2022

I have updated the snap file and changelog. :)

Copy link
Member

@STRRL STRRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@STRRL
Copy link
Member

STRRL commented Jun 15, 2022

/cc @YangKeao @iguoyr

PTAL

@ti-chi-bot ti-chi-bot requested a review from iguoyr June 15, 2022 07:55
@afterlook
Copy link
Contributor Author

Thanks @STRRL. Still one e2e test failing. Tried getting pod in post run, but it was already deleted.

@STRRL
Copy link
Member

STRRL commented Jun 15, 2022

Thanks @STRRL. Still one e2e test failing. Tried getting pod in post run, but it was already deleted.

e2e test are flaky 🥲, I would retry them

@xlgao-zju
Copy link
Member

maybe we should figure out how to upgrade the chaos mesh and migrate the existing resource, before we merge this PR 🤔

@xlgao-zju
Copy link
Member

look like only new installation will use chaos-mesh, that will be fine.

Copy link
Member

@xlgao-zju xlgao-zju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@STRRL
Copy link
Member

STRRL commented Jun 20, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 548ccb7

@ti-chi-bot ti-chi-bot merged commit 68b0b7b into chaos-mesh:master Jun 20, 2022
stephen-harris pushed a commit to stephen-harris/chaos-mesh that referenced this pull request Jun 23, 2022
* renamed all occurances of chaos testing to chaos-mesh

Signed-off-by: kkulgawczuk <29754364+krystian-kulgawczuk@users.noreply.github.com>

* added namespace refactore to changed section

Signed-off-by: kkulgawczuk <29754364+krystian-kulgawczuk@users.noreply.github.com>

* rename namespace in hidden directories

Signed-off-by: kkulgawczuk <29754364+krystian-kulgawczuk@users.noreply.github.com>

* chore: update snap file

Signed-off-by: STRRL <im@strrl.dev>

Co-authored-by: STRRL <im@strrl.dev>
Signed-off-by: Stephen Harris <stephen.harris1@kaluza.com>
STRRL added a commit to Garima-Negi/chaos-mesh that referenced this pull request Sep 13, 2022
* renamed all occurances of chaos testing to chaos-mesh

Signed-off-by: kkulgawczuk <29754364+krystian-kulgawczuk@users.noreply.github.com>

* added namespace refactore to changed section

Signed-off-by: kkulgawczuk <29754364+krystian-kulgawczuk@users.noreply.github.com>

* rename namespace in hidden directories

Signed-off-by: kkulgawczuk <29754364+krystian-kulgawczuk@users.noreply.github.com>

* chore: update snap file

Signed-off-by: STRRL <im@strrl.dev>

Co-authored-by: STRRL <im@strrl.dev>
Signed-off-by: STRRL <im@strrl.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use chaos-mesh instead of chaos-testing in anywhere
5 participants