Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JVMChaos: update the error message that can be ignored #3415

Merged
merged 3 commits into from
Jul 4, 2022

Conversation

WangXiangUSTC
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC commented Jun 30, 2022

Signed-off-by: xiang xiang13225080@163.com

What problem does this PR solve?

fix issue #3330
The agent attached success, but return error, this error can be ignored

What's changed and how it works?

Related changes

  • Need to update chaos-mesh/website
  • Need to update Dashboard UI
  • Need to cheery-pick to release branches
    • release-2.2
    • release-2.1

Checklist

CHANGELOG

  • I have updated the CHANGELOG.md
  • I have labeled this PR with "no-need-update-changelog"

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

Side effects

  • Breaking backward compatibility

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

Signed-off-by: xiang <xiang13225080@163.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 30, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Andrewmatilde
  • fewdan

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: xiang <xiang13225080@163.com>
@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #3415 (2f3ea19) into master (b80f0ca) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3415      +/-   ##
==========================================
- Coverage   41.13%   41.08%   -0.06%     
==========================================
  Files         165      165              
  Lines       13851    13851              
==========================================
- Hits         5698     5690       -8     
- Misses       7721     7727       +6     
- Partials      432      434       +2     
Impacted Files Coverage Δ
pkg/chaosdaemon/jvm_server.go 0.00% <0.00%> (ø)
pkg/workflow/controllers/chaos_node_reconciler.go 58.16% <0.00%> (-3.16%) ⬇️
pkg/selector/generic/mode.go 25.64% <0.00%> (-2.57%) ⬇️
pkg/workflow/controllers/deadline_reconciler.go 64.44% <0.00%> (-2.23%) ⬇️
api/v1alpha1/zz_generated.chaosmesh.go 57.04% <0.00%> (ø)
controllers/statuscheck/controller.go 84.14% <0.00%> (+4.87%) ⬆️
.../workflow/controllers/abort_workflow_reconciler.go 57.14% <0.00%> (+8.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b80f0ca...2f3ea19. Read the comment docs.

Copy link
Member

@fewdan fewdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member

cwen0 commented Jul 1, 2022

/merge

@ti-chi-bot
Copy link
Member

@cwen0: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@cwen0
Copy link
Member

cwen0 commented Jul 1, 2022

/merge

@ti-chi-bot
Copy link
Member

@cwen0: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@WangXiangUSTC
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@WangXiangUSTC: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Member

@Andrewmatilde Andrewmatilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2f3ea19

@ti-chi-bot ti-chi-bot merged commit 6a379cf into chaos-mesh:master Jul 4, 2022
STRRL pushed a commit to Garima-Negi/chaos-mesh that referenced this pull request Sep 13, 2022
* update message

Signed-off-by: xiang <xiang13225080@163.com>

* update CHANGELOG

Signed-off-by: xiang <xiang13225080@163.com>

Co-authored-by: Cwen Yin <cwenyin0@gmail.com>
Signed-off-by: STRRL <im@strrl.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants