multicluster: support inject / recover on remote cluster #3453

YangKeao · 2022-07-14T07:24:47Z

What problem does this PR solve?

Inject / recover chaos on remote cluster

What's changed and how it works?

Documentation: chaos-mesh/website#365.

Add a controller on manager cluster to synchronous create new chaos or remove old ones
Add a controller for new cluster to watch the changes on remote cluster

TODO:

Synchronize the status
Add documents to clarify the workflow of these two controllers.

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

…roller-manager Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

Signed-off-by: STRRL <im@strrl.dev>

Signed-off-by: FingerLeader <wanxfinger@gmail.com>

Signed-off-by: STRRL <im@strrl.dev>

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

…elm-pkg Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

…integrate-fingerleader-injection

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

…eader-injection Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

ti-chi-bot · 2022-07-14T07:24:48Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

cwen0

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

sonatype-lift · 2022-07-14T07:41:42Z

controllers/multicluster/remotecluster/controller.go

+
+			var values map[string]interface{}
+			if obj.Spec.ConfigOverride != nil {
+				err = json.Unmarshal(obj.Spec.ConfigOverride, values)


SA1014: json.Unmarshal expects to unmarshal into a pointer, but the provided value is not a pointer

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

Signed-off-by: STRRL <im@strrl.dev>

Signed-off-by: cwen0 <cwenyin0@gmail.com>

cwen0

LGTM

cwen0 · 2022-11-20T12:14:25Z

/merge

ti-chi-bot · 2022-11-20T12:14:28Z

This pull request has been accepted and is ready to merge.

Commit hash: 4cacfa6

STRRL · 2022-11-20T12:24:10Z

/hold

please update the changelog, it should not remove any entries.

Signed-off-by: cwen0 <cwenyin0@gmail.com>

cwen0 · 2022-11-20T12:48:10Z

/merge

ti-chi-bot · 2022-11-20T12:48:13Z

This pull request has been accepted and is ready to merge.

Commit hash: 2b116aa

ti-chi-bot · 2022-11-20T12:58:47Z

In response to a cherrypick label: new pull request created: #3802.

* add remotecluster type Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add the infrastructure to operate multiple clusters Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * remove clientset Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * modify changelog Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add license to the remote-cluster.yaml Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * fix Wrapf arguments Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * make check Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * make the lock private Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * chore: helm chart integration and basic interface Signed-off-by: STRRL <im@strrl.dev> * apply remote chaos Signed-off-by: FingerLeader <wanxfinger@gmail.com> * chore: complete the implementation of ReleaseService Signed-off-by: STRRL <im@strrl.dev> * chore: update changelog Signed-off-by: STRRL <im@strrl.dev> * install chaos mesh Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add CHANGELOG Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * inject successfully Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * clear finalizer successfully Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add more logs Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * chore: helm chart integration and basic interface Signed-off-by: STRRL <im@strrl.dev> * chore: complete the implementation of ReleaseService Signed-off-by: STRRL <im@strrl.dev> * chore: update changelog Signed-off-by: STRRL <im@strrl.dev> * chore: fix make check Signed-off-by: STRRL <im@strrl.dev> * chore: update lincense checker config file Signed-off-by: STRRL <im@strrl.dev> * test: mark examples of helm as integration test Signed-off-by: STRRL <im@strrl.dev> * add condition initialization for remote cluster Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * upgrade chaosmesh release version to 2.4.1 Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * upgrade chaosmesh release version to 2.4.1 Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * upgrade chaosmesh release version to 2.4.1 Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * fix CI Signed-off-by: cwen0 <cwenyin0@gmail.com> * fix revive checks Signed-off-by: cwen0 <cwenyin0@gmail.com> * Run make check to format code Signed-off-by: cwen0 <cwenyin0@gmail.com> * fix comment controller Signed-off-by: cwen0 <cwenyin0@gmail.com> * update changelog Signed-off-by: cwen0 <cwenyin0@gmail.com> Signed-off-by: YangKeao <yangkeao@chunibyo.icu> Signed-off-by: STRRL <im@strrl.dev> Signed-off-by: FingerLeader <wanxfinger@gmail.com> Signed-off-by: cwen0 <cwenyin0@gmail.com> Co-authored-by: STRRL <im@strrl.dev> Co-authored-by: FingerLeader <wanxfinger@gmail.com> Co-authored-by: cwen0 <cwenyin0@gmail.com> Signed-off-by: YangKeao <yangkeao@chunibyo.icu> Signed-off-by: STRRL <im@strrl.dev> Signed-off-by: FingerLeader <wanxfinger@gmail.com> Signed-off-by: cwen0 <cwenyin0@gmail.com> Co-authored-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: STRRL <im@strrl.dev> Co-authored-by: FingerLeader <wanxfinger@gmail.com> Co-authored-by: cwen0 <cwenyin0@gmail.com>

mdnyeemakhtar · 2023-04-03T15:59:00Z

Hello @YangKeao,

I'd greatly appreciate if I can get some information on TODO 1. Synchronize the status. Is it being done in a different PR?
Here is my more detailed question #3396 (comment)

YangKeao and others added 21 commits June 8, 2022 11:25

add remotecluster type

9b44a42

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

add the infrastructure to operate multiple clusters

0d50d13

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

remove clientset

99edc89

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

modify changelog

f111d79

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

add license to the remote-cluster.yaml

3932240

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

fix Wrapf arguments

32e6a36

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

make check

9921ccf

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

make the lock private

d6bedfc

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

Merge remote-tracking branch 'upstream/master' into configurable-cont…

3128da3

…roller-manager Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

chore: helm chart integration and basic interface

267148d

Signed-off-by: STRRL <im@strrl.dev>

apply remote chaos

c9ed448

Signed-off-by: FingerLeader <wanxfinger@gmail.com>

chore: complete the implementation of ReleaseService

464a6c7

Signed-off-by: STRRL <im@strrl.dev>

chore: update changelog

0e7e50e

Signed-off-by: STRRL <im@strrl.dev>

install chaos mesh

c72f006

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

add CHANGELOG

73d8b19

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

Merge remote-tracking branch 'upstream/master' into integrate-strrl-h…

23999a3

…elm-pkg Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

Merge remote-tracking branch 'fingerleader/remote-chaos-inject' into …

6c47f44

…integrate-fingerleader-injection

inject successfully

23f3ff2

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

Merge remote-tracking branch 'upstream/master' into integrate-fingerl…

8b165c3

…eader-injection Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

clear finalizer successfully

3ad24c0

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

add more logs

749e20b

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

YangKeao mentioned this pull request Jul 14, 2022

[multicluster] chaos injection and status synchronization #3396

Closed

ti-chi-bot added the size/XXL label Jul 14, 2022

ti-chi-bot requested review from STRRL and xlgao-zju July 14, 2022 07:25

sonatype-lift bot reviewed Jul 14, 2022

View reviewed changes

ti-chi-bot added the needs-rebase label Aug 6, 2022

STRRL added 2 commits August 12, 2022 16:37

chore: helm chart integration and basic interface

3655610

Signed-off-by: STRRL <im@strrl.dev>

chore: complete the implementation of ReleaseService

3443d01

Signed-off-by: STRRL <im@strrl.dev>

fix conflicts

0daf001

Signed-off-by: cwen0 <cwenyin0@gmail.com>

ti-chi-bot removed the needs-rebase label Nov 20, 2022

cwen0 added 5 commits November 20, 2022 12:28

fix CI

ba07f13

Signed-off-by: cwen0 <cwenyin0@gmail.com>

fix revive checks

daced2c

Signed-off-by: cwen0 <cwenyin0@gmail.com>

Run make check to format code

24c87ac

Signed-off-by: cwen0 <cwenyin0@gmail.com>

fix comment controller

477a7ce

Signed-off-by: cwen0 <cwenyin0@gmail.com>

Merge branch 'master' into integrate-fingerleader-injection

4cacfa6

cwen0 added the needs-cherry-pick-release-2.5 label Nov 20, 2022

cwen0 approved these changes Nov 20, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 label Nov 20, 2022

cwen0 added the require-LGT1 label Nov 20, 2022

ti-chi-bot added the status/can-merge label Nov 20, 2022

chaos-mesh deleted a comment from ti-chi-bot Nov 20, 2022

ti-chi-bot added do-not-merge/hold and removed status/can-merge labels Nov 20, 2022

cwen0 force-pushed the integrate-fingerleader-injection branch from d27c313 to 5e0ee97 Compare November 20, 2022 12:33

update changelog

2b116aa

Signed-off-by: cwen0 <cwenyin0@gmail.com>

cwen0 force-pushed the integrate-fingerleader-injection branch from 5e0ee97 to 2b116aa Compare November 20, 2022 12:36

cwen0 removed the do-not-merge/hold label Nov 20, 2022

ti-chi-bot added the status/can-merge label Nov 20, 2022

cwen0 merged commit ecbaf49 into chaos-mesh:master Nov 20, 2022

ti-chi-bot mentioned this pull request Nov 20, 2022

multicluster: support inject / recover on remote cluster (#3453) #3802

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

multicluster: support inject / recover on remote cluster #3453

multicluster: support inject / recover on remote cluster #3453

YangKeao commented Jul 14, 2022 •

edited by g1eny0ung

ti-chi-bot commented Jul 14, 2022 •

edited

sonatype-lift bot Jul 14, 2022

cwen0 left a comment

cwen0 commented Nov 20, 2022

ti-chi-bot commented Nov 20, 2022

STRRL commented Nov 20, 2022

cwen0 commented Nov 20, 2022

ti-chi-bot commented Nov 20, 2022

ti-chi-bot commented Nov 20, 2022

mdnyeemakhtar commented Apr 3, 2023

multicluster: support inject / recover on remote cluster #3453

multicluster: support inject / recover on remote cluster #3453

Conversation

YangKeao commented Jul 14, 2022 • edited by g1eny0ung

What problem does this PR solve?

What's changed and how it works?

ti-chi-bot commented Jul 14, 2022 • edited

sonatype-lift bot Jul 14, 2022

Choose a reason for hiding this comment

cwen0 left a comment

Choose a reason for hiding this comment

cwen0 commented Nov 20, 2022

ti-chi-bot commented Nov 20, 2022

STRRL commented Nov 20, 2022

cwen0 commented Nov 20, 2022

ti-chi-bot commented Nov 20, 2022

ti-chi-bot commented Nov 20, 2022

mdnyeemakhtar commented Apr 3, 2023

YangKeao commented Jul 14, 2022 •

edited by g1eny0ung

ti-chi-bot commented Jul 14, 2022 •

edited