Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add TLS support for HTTPChaos #3549

Closed
wants to merge 13 commits into from
Closed

Conversation

Hexilee
Copy link
Member

@Hexilee Hexilee commented Aug 11, 2022

What problem does this PR solve?

Current HTTPChaos cannot inject TLS connections, in this PR we can make it.

What's changed and how it works?

Users should provide cert, key and optional ca by a k8s Secret resource.

Related changes

  • This change also requires further upadtes to chaos-mesh/website (e.g. docs)
  • This change also requires further updates to UI interface
  • Need to cheery-pick to release branches
    • release-2.3
    • release-2.2

Checklist

CHANGELOG

  • I have updated the CHANGELOG.md
  • I have labeled this PR with "no-need-update-changelog"

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

Side effects

  • Breaking backward compatibility

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

Signed-off-by: xixi <i@hexilee.me>
Signed-off-by: xixi <i@hexilee.me>
Signed-off-by: xixi <i@hexilee.me>
Signed-off-by: xixi <i@hexilee.me>
Signed-off-by: xixi <i@hexilee.me>
Signed-off-by: xixi <i@hexilee.me>
Signed-off-by: xixi <i@hexilee.me>
Signed-off-by: xixi <i@hexilee.me>
Signed-off-by: xixi <i@hexilee.me>
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from cwen0 August 11, 2022 14:52
@Hexilee Hexilee mentioned this pull request Aug 11, 2022
10 tasks
Signed-off-by: xixi <i@hexilee.me>
@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #3549 (4db1bd4) into master (54d9a8a) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3549      +/-   ##
==========================================
- Coverage   40.10%   40.07%   -0.04%     
==========================================
  Files         166      166              
  Lines       14191    14197       +6     
==========================================
- Hits         5692     5689       -3     
- Misses       8065     8073       +8     
- Partials      434      435       +1     
Impacted Files Coverage Δ
api/v1alpha1/httpchaos_types.go 0.00% <ø> (ø)
pkg/chaosdaemon/httpchaos_server.go 0.00% <0.00%> (ø)
pkg/workflow/controllers/deadline_reconciler.go 64.44% <0.00%> (-2.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54d9a8a...4db1bd4. Read the comment docs.

Signed-off-by: xixi <i@hexilee.me>
@ti-chi-bot
Copy link
Member

@Hexilee: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@STRRL
Copy link
Member

STRRL commented Nov 15, 2022

successor: #3647

@STRRL STRRL closed this Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants