Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to add Pod securityContext for controller-manager and dashboard #3603

Merged
merged 12 commits into from Sep 22, 2022
Merged

Ability to add Pod securityContext for controller-manager and dashboard #3603

merged 12 commits into from Sep 22, 2022

Conversation

alekczapski
Copy link
Contributor

@alekczapski alekczapski commented Sep 6, 2022

Signed-off-by: Aleksander Czapski alekczapski@gmail.com

What problem does this PR solve?

This PR allows for configuring Pod securityContext for controller-manager and dashboard in Helm template (closes #3598
)

What's changed and how it works?

A new controller.securityContext and dashboard.securityContext configuration option in values.yaml is used for controler-manager and dashboard securityContext field.
For more details refer to Kubernetes documentation.

Related changes

  • This change also requires further updates to the website (e.g. docs)
  • This change also requires further updates to the UI interface
  • Need to cheery-pick to release branches
    • release-2.3
    • release-2.2

Checklist

CHANGELOG

  • I have updated the CHANGELOG.md
  • I have labeled this PR with "no-need-update-changelog"

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

Side effects

  • Breaking backward compatibility

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

alekczapski and others added 2 commits September 6, 2022 06:23
Signed-off-by: Aleksander Czapski <alekczapski@gmail.com>
Signed-off-by: Aleksander Czapski <alekczapski@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 6, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • STRRL

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

Welcome @alekczapski!

It looks like this is your first PR to chaos-mesh/chaos-mesh 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to chaos-mesh/chaos-mesh. 😃

Signed-off-by: Aleksander Czapski <alekczapski@gmail.com>
@STRRL STRRL self-assigned this Sep 6, 2022
@STRRL
Copy link
Member

STRRL commented Sep 6, 2022

Hi @alekczapski, thanks for your contribution!!!

There are several files that need updates. You could execute make check on your local machine, then commit the changes. :)

alekczapski and others added 2 commits September 6, 2022 23:08
Signed-off-by: Aleksander Czapski <alekczapski@gmail.com>
@alekczapski
Copy link
Contributor Author

Hi @STRRL
the missing file has been updated :)

Copy link
Member

@STRRL STRRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@STRRL
Copy link
Member

STRRL commented Sep 13, 2022

/merge

@ti-chi-bot
Copy link
Member

@STRRL: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@STRRL
Copy link
Member

STRRL commented Sep 22, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 03452ff

@ti-chi-bot
Copy link
Member

@alekczapski: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 0f66cb0 into chaos-mesh:master Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] securityContext for controller-manager and dashboard
3 participants