New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to add Pod securityContext for controller-manager and dashboard #3603
Conversation
Signed-off-by: Aleksander Czapski <alekczapski@gmail.com>
Signed-off-by: Aleksander Czapski <alekczapski@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Welcome @alekczapski! |
Signed-off-by: Aleksander Czapski <alekczapski@gmail.com>
Hi @alekczapski, thanks for your contribution!!! There are several files that need updates. You could execute |
Signed-off-by: Aleksander Czapski <alekczapski@gmail.com>
Hi @STRRL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/merge |
@STRRL: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 03452ff
|
@alekczapski: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: Aleksander Czapski alekczapski@gmail.com
What problem does this PR solve?
This PR allows for configuring Pod securityContext for controller-manager and dashboard in Helm template (closes #3598
)
What's changed and how it works?
A new controller.securityContext and dashboard.securityContext configuration option in values.yaml is used for controler-manager and dashboard securityContext field.
For more details refer to Kubernetes documentation.
Related changes
UI interface
Checklist
CHANGELOG
CHANGELOG.md
Tests
Side effects
DCO
If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it: