Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove the explicit use of pingcap/log #3674

Merged
merged 4 commits into from Sep 26, 2022

Conversation

g1eny0ung
Copy link
Member

Signed-off-by: Yue Yang g1enyy0ung@gmail.com

What problem does this PR solve?

Related to #2752.

What's changed and how it works?

Related changes

  • This change also requires further updates to the website (e.g. docs)
  • This change also requires further updates to the UI interface
  • Need to cheery-pick to release branches
    • release-2.4
    • release-2.3
    • release-2.2

Checklist

CHANGELOG

  • I have updated the CHANGELOG.md
  • I have labeled this PR with "no-need-update-changelog"

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

Side effects

  • Breaking backward compatibility

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 26, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • STRRL

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Merging #3674 (a503908) into master (c7f4004) will decrease coverage by 0.46%.
The diff coverage is 4.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3674      +/-   ##
==========================================
- Coverage   40.54%   40.07%   -0.47%     
==========================================
  Files         166      166              
  Lines       14171    14191      +20     
==========================================
- Hits         5745     5687      -58     
- Misses       7999     8068      +69     
- Partials      427      436       +9     
Impacted Files Coverage Δ
api/v1alpha1/physical_machine_chaos_types.go 46.15% <ø> (ø)
controllers/chaosimpl/jvmchaos/impl.go 36.96% <0.00%> (-0.69%) ⬇️
pkg/chaosdaemon/blockchaos_server_linux.go 0.00% <0.00%> (ø)
pkg/chaosdaemon/jvm_server.go 0.00% <0.00%> (ø)
...md/chaos-controller-manager/provider/controller.go 40.70% <100.00%> (ø)
.../workflow/controllers/workflow_entry_reconciler.go 47.02% <0.00%> (-18.92%) ⬇️
.../workflow/controllers/abort_workflow_reconciler.go 48.97% <0.00%> (-6.13%) ⬇️
pkg/workflow/controllers/abort_node_reconciler.go 15.11% <0.00%> (-3.49%) ⬇️
pkg/selector/generic/mode.go 25.64% <0.00%> (-2.57%) ⬇️
pkg/workflow/controllers/deadline_reconciler.go 64.44% <0.00%> (-2.23%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e188588...a503908. Read the comment docs.

Copy link
Member

@STRRL STRRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@g1eny0ung g1eny0ung added type/bug-fix A bug needs to be fixed. chaos/jvm labels Sep 26, 2022
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
@g1eny0ung g1eny0ung merged commit ed62c84 into chaos-mesh:master Sep 26, 2022
@g1eny0ung g1eny0ung deleted the fix/remove-pingcap-log branch September 26, 2022 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants