Dashboard rwo pvc restart

[torbendury]

What problem does this PR solve?

Close #3876

What's changed and how it works?

I have changed the dashboards updateStrategy. The PersistentVolumeClaim for the dashboard is created with the accessMode ReadWriteOnce, which does not allow the dashboard to do a rolling restart because the blue version of the dashboard won't be shutdown until the green version is up and running.

This lead to problems when doing a kubectl rollout-restart deployment chaos-dashboard because the new dashboard Pod could not mount the PVC.

Related changes

• This change also requires further updates to the website (e.g. docs)
• This change also requires further updates to the UI interface
• Need to cheery-pick to release branches
  • release-2.5
  • release-2.4

Checklist

CHANGELOG

• I have updated the CHANGELOG.md
• I have labeled this PR with "no-need-update-changelog"

Tests

• Unit test
• E2E test
• No code
• Manual test (add steps below)

steps:

• Install the ChaosMesh + dashboard using a helm install command
  • configure the dashboard to be enabled and use a PersistentVolumeClaim of arbitrary size
• Change the update strategy as mentioned in this PR
• Watch the dashboard rollout-restart instead of being stuck

Side effects

• Breaking backward compatibility

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• STRRL
• g1eny0ung

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[ti-chi-bot]

Welcome @torbendury!

It looks like this is your first PR to chaos-mesh/chaos-mesh 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to chaos-mesh/chaos-mesh. 😃

[torbendury]

Apparently it's not that easy to sign-off commits using GitHub Desktop, anyway I was able to force push over my mistake. Open for comments/review!

[g1eny0ung]

Apparently it's not that easy to sign-off commits using GitHub Desktop, anyway I was able to force push over my mistake. Open for comments/review!

Ah, I'm also facing this problem before. The GitHub desktop lacks sign-off commits support. :(

[torbendury]

Are those failing checks related to my PR? I took a quick look but they don't really seem to correlate imho

[g1eny0ung]

I'm ok with this solution of setting the strategy to type: Recreate because real-time availability of the dashboard is not so critical.

We can also make a separate option for ReadWriteOnce PV or PVC, like:

strategy:
  {{- if eq .Values.dashboard.persistentVolume.accessModes "ReadWriteOnce" }}
  type: Recreate
  {{- else }}
  # ...

I think both are fine. What do you think? @STRRL

[g1eny0ung]

Are those failing checks related to my PR? I took a quick look but they don't really seem to correlate IMHO

@torbendury It can be said to be irrelevant. These errors are not about the charts themselves, they are just used to prevent some omissions (because of the need to synchronize the chart's changes to install.sh).

Run make install.sh in your local and commit again can pass the checks. 😃

[torbendury]

I also thought of making it depending on the accessMode of the PVC itself, but it is (at least at the moment!) hardcoded here by the Helm Chart itself, if I didn't overlook anything

[g1eny0ung]

I also thought of making it depending on the accessMode of the PVC itself, but it is (at least at the moment!) hardcoded here by the Helm Chart itself, if I didn't overlook anything

Good catch! Then I think about the accessMode we can consider in a separate PR.

[STRRL]

LGTM!

[STRRL]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 83b4cb9

[ti-chi-bot]

@torbendury: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-2.5: #3975.