-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refine dashboard config #4008
chore: refine dashboard config #4008
Conversation
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #4008 +/- ##
==========================================
- Coverage 38.91% 38.56% -0.35%
==========================================
Files 165 167 +2
Lines 13698 13734 +36
==========================================
- Hits 5330 5297 -33
- Misses 7944 8003 +59
- Partials 424 434 +10
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
Also, it requires |
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Yes, I have updated the swagger docs. |
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
@STRRL: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 8cf0633
|
In response to a cherrypick label: new pull request created to branch |
* This is an automated cherry-pick of #4008 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> * Update CHANGELOG.md Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> --------- Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> Co-authored-by: Yue Yang <g1enyy0ung@gmail.com>
What's changed and how it works?
This PR moves the
TTLConfig
topkg/config
and creates a new structTTLConfigWithStringTime
to consume the config from env. This change aims to isolate the TTL config definition from the implementation.Related changes
UI interface
Checklist
CHANGELOG
CHANGELOG.md
Tests
Side effects
DCO
If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it: