Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refine dashboard config #4008

Merged
merged 13 commits into from
Apr 13, 2023

Conversation

g1eny0ung
Copy link
Member

What's changed and how it works?

This PR moves the TTLConfig to pkg/config and creates a new struct TTLConfigWithStringTime to consume the config from env. This change aims to isolate the TTL config definition from the implementation.

Related changes

  • This change also requires further updates to the website (e.g. docs)
  • This change also requires further updates to the UI interface
  • Need to cheery-pick to release branches
    • release-2.5
    • release-2.4

Checklist

CHANGELOG

  • I have updated the CHANGELOG.md
  • I have labeled this PR with "no-need-update-changelog"

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

Side effects

  • Breaking backward compatibility

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 11, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • STRRL

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #4008 (8cf0633) into master (ede2f91) will decrease coverage by 0.35%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4008      +/-   ##
==========================================
- Coverage   38.91%   38.56%   -0.35%     
==========================================
  Files         165      167       +2     
  Lines       13698    13734      +36     
==========================================
- Hits         5330     5297      -33     
- Misses       7944     8003      +59     
- Partials      424      434      +10     
Impacted Files Coverage Δ
pkg/dashboard/apiserver/archive/archive.go 31.93% <ø> (ø)
pkg/dashboard/apiserver/event/event.go 19.51% <ø> (ø)
pkg/config/dashboard.go 40.62% <75.00%> (ø)

... and 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25a841a...8cf0633. Read the comment docs.

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
@ti-chi-bot ti-chi-bot added size/XL and removed size/L labels Apr 11, 2023
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Copy link
Member

@STRRL STRRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

pkg/config/dashboard_test.go Outdated Show resolved Hide resolved
@STRRL
Copy link
Member

STRRL commented Apr 12, 2023

Also, it requires make check to update generated codes.

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
@g1eny0ung
Copy link
Member Author

Also, it requires make check to update generated codes.

Yes, I have updated the swagger docs.

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
@g1eny0ung g1eny0ung requested a review from STRRL April 12, 2023 08:22
Copy link
Member

@STRRL STRRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@STRRL
Copy link
Member

STRRL commented Apr 13, 2023

/merge

@ti-chi-bot
Copy link
Member

@STRRL: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@STRRL
Copy link
Member

STRRL commented Apr 13, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8cf0633

@ti-chi-bot ti-chi-bot merged commit e5c03c2 into chaos-mesh:master Apr 13, 2023
59 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-2.5: #4011.

@g1eny0ung g1eny0ung deleted the chore/refine-dashboard-config branch April 13, 2023 15:00
g1eny0ung added a commit that referenced this pull request Apr 13, 2023
* This is an automated cherry-pick of #4008

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* Update CHANGELOG.md

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

---------

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Co-authored-by: Yue Yang <g1enyy0ung@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants