-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use helm values to set chaos-daemon capabilities #4030
use helm values to set chaos-daemon capabilities #4030
Conversation
Signed-off-by: nio <nioshield@gmail.com>
@nioshield Thanks for your contribution! This pr can't fix #3917, but is is useful. We can merge it. |
capabilities: | ||
add: | ||
- SYS_PTRACE | ||
- NET_ADMIN |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we should append NET_RAW
here? also cc @dsharp-pivotal
ref: #3917 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so. Let me add it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
Signed-off-by: nio <nioshield@gmail.com>
/cherrypick release-2.5 |
@STRRL: #4030 failed to apply on top of branch "release-2.5":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What problem does this PR solve?
Flexible configuration of capabilities is expected in some test scenarios
What's changed and how it works?
Replace the chaos-daemon-daemonset.yaml capabilities configuration with template variables
Related changes
fixes #3917
UI interface
Checklist
CHANGELOG
CHANGELOG.md
Tests
Side effects
DCO
If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it: