Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine logging in pkg/selector/physicalmachine #4037

Merged
merged 4 commits into from
May 10, 2023

Conversation

g1eny0ung
Copy link
Member

@g1eny0ung g1eny0ung commented May 7, 2023

What problem does this PR solve?

Close #2887

What's changed and how it works?

Related changes

  • This change also requires further updates to the website (e.g. docs)
  • This change also requires further updates to the UI interface
  • Need to cheery-pick to release branches
    • release-2.5
    • release-2.4

Checklist

CHANGELOG

  • I have updated the CHANGELOG.md
  • I have labeled this PR with "no-need-update-changelog"

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

Side effects

  • Breaking backward compatibility

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
@codecov
Copy link

codecov bot commented May 7, 2023

Codecov Report

Merging #4037 (1626737) into master (7c75a0e) will decrease coverage by 0.07%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4037      +/-   ##
==========================================
- Coverage   38.53%   38.46%   -0.07%     
==========================================
  Files         167      167              
  Lines       13734    13729       -5     
==========================================
- Hits         5292     5281      -11     
- Misses       8010     8013       +3     
- Partials      432      435       +3     
Impacted Files Coverage Δ
pkg/selector/physicalmachine/selector.go 35.22% <50.00%> (+1.07%) ⬆️

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c75a0e...1626737. Read the comment docs.

@g1eny0ung g1eny0ung requested a review from cwen0 May 8, 2023 05:38
@STRRL
Copy link
Member

STRRL commented May 9, 2023

/lgtm

@chaotic-prow chaotic-prow bot removed the lgtm label May 10, 2023
@chaotic-prow
Copy link

chaotic-prow bot commented May 10, 2023

New changes are detected. LGTM label has been removed.

@g1eny0ung
Copy link
Member Author

/lgtm

@chaotic-prow
Copy link

chaotic-prow bot commented May 10, 2023

@g1eny0ung: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chaotic-prow
Copy link

chaotic-prow bot commented May 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: g1eny0ung, STRRL

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@g1eny0ung g1eny0ung merged commit 08185e7 into chaos-mesh:master May 10, 2023
55 of 57 checks passed
@g1eny0ung g1eny0ung deleted the close-2887 branch May 10, 2023 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants