-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine logging in pkg/selector/physicalmachine
#4037
Conversation
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #4037 +/- ##
==========================================
- Coverage 38.53% 38.46% -0.07%
==========================================
Files 167 167
Lines 13734 13729 -5
==========================================
- Hits 5292 5281 -11
- Misses 8010 8013 +3
- Partials 432 435 +3
... and 10 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
/lgtm |
New changes are detected. LGTM label has been removed. |
/lgtm |
@g1eny0ung: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: g1eny0ung, STRRL The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Close #2887
What's changed and how it works?
Related changes
UI interface
Checklist
CHANGELOG
CHANGELOG.md
Tests
Side effects
DCO
If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it: