-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: optimize allInjected
and allRecovered
states
#4199
refactor: optimize allInjected
and allRecovered
states
#4199
Conversation
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
/cherrypick release-2.6 |
@g1eny0ung: once the present PR merges, I will cherry-pick it on top of release-2.6 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #4199 +/- ##
==========================================
- Coverage 38.43% 38.36% -0.07%
==========================================
Files 167 169 +2
Lines 13787 13900 +113
==========================================
+ Hits 5299 5333 +34
- Misses 8052 8131 +79
Partials 436 436
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cwen0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
@g1eny0ung: #4199 failed to apply on top of branch "release-2.6":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…h#4199) * refactor: allInjected and allRecovered conditions Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: update Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * Update CHANGELOG.md Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: add tests Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * Update condition_suite_test.go Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * Update controller_test.go Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: remove unnecessary else Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: add comments Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * Update ci.yml Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> --------- Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
…4243) Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
…h#4199) * refactor: allInjected and allRecovered conditions Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: update Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * Update CHANGELOG.md Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: add tests Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * Update condition_suite_test.go Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * Update controller_test.go Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: remove unnecessary else Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: add comments Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * Update ci.yml Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> --------- Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
What problem does this PR solve?
Optimize
allInjected
andallRecovered
states when targets are not selected.Before:
After:
What's changed and how it works?
Instead of arbitrarily setting the initial values of
allInjected
andallRecovered
, the value is assigned based on the current selected state.Related changes
UI interface
Cherry-pick to release branches (optional)
Checklist
CHANGELOG
CHANGELOG.md
Tests
Side effects
DCO
If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it: