Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecated Stream method in pkg/ctrl/server/exec.go #4380

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

zhanluxianshen
Copy link
Contributor

What problem does this PR solve?

Fix unused code and clean method in pkg/ctrl/server/exec.go
image

image

What's changed and how it works?

Related changes

  • This change also requires further updates to the website (e.g. docs)
  • This change also requires further updates to the UI interface

Cherry-pick to release branches (optional)

This PR should be cherry-picked to the following release branches:

  • release-2.6
  • release-2.5

Checklist

CHANGELOG

Must include at least one of them.

  • I have updated the CHANGELOG.md
  • I have labeled this PR with "no-need-update-changelog"

Tests

Must include at least one of them.

  • Unit test
  • E2E test
  • Manual test

Side effects

  • Breaking backward compatibility

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

Signed-off-by: zhanluxianshen <zhanluxianshen@163.com>
@chaotic-prow chaotic-prow bot requested review from g1eny0ung and STRRL March 21, 2024 01:39
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.88%. Comparing base (12d4810) to head (8027273).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4380      +/-   ##
==========================================
+ Coverage   38.72%   38.88%   +0.15%     
==========================================
  Files         169      169              
  Lines       13953    13953              
==========================================
+ Hits         5403     5425      +22     
+ Misses       8102     8086      -16     
+ Partials      448      442       -6     

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12d4810...8027273. Read the comment docs.

Copy link
Member

@g1eny0ung g1eny0ung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chaotic-prow
Copy link

chaotic-prow bot commented Mar 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: g1eny0ung

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@g1eny0ung g1eny0ung added the no-need-update-changelog Skip CI check "Must Update CHANGELOG" for this PR label Mar 31, 2024
@g1eny0ung g1eny0ung changed the title Fix unused code and clean method in pkg/ctrl/server/exec.go fix: deprecated Stream method in pkg/ctrl/server/exec.go Mar 31, 2024
@zhanluxianshen
Copy link
Contributor Author

thanks

@g1eny0ung g1eny0ung merged commit e23120f into chaos-mesh:master Apr 2, 2024
53 of 56 checks passed
@zhanluxianshen zhanluxianshen deleted the fit-ctrl-server-exec branch April 2, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved no-need-update-changelog Skip CI check "Must Update CHANGELOG" for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants