Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added openshift-specific helm values #4404

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

var-i
Copy link

@var-i var-i commented Apr 23, 2024

What problem does this PR solve?

Removes need for manual configuration in Openshift environments

What's changed and how it works?

An additional RoleBinding is added to add the chaos-daemon and chaos-dns-server to the "privileged" openshift SCC

Related changes

  • This change also requires further updates to the website (e.g. docs)
  • This change also requires further updates to the UI interface

Cherry-pick to release branches (optional)

This PR should be cherry-picked to the following release branches:

  • release-2.6
  • release-2.5

Checklist

CHANGELOG

Must include at least one of them.

  • I have updated the CHANGELOG.md
  • I have labeled this PR with "no-need-update-changelog"

Tests

Must include at least one of them.

  • Unit test
  • E2E test
  • Manual test

Side effects

  • Breaking backward compatibility

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

Signed-off-by: Ivar Cmrecak <ivar.cmrecak@lego.com>
@STRRL
Copy link
Member

STRRL commented Apr 30, 2024

Hi @var-i , thanks for your contribution, however we do not encouraged that intruducing too many things about platform-specific configurations.

For example, we would also NOT introduce dedicated configuration fields for other kubernetes distribution.

It's welcome to make a section in FAQ to introduce your solution with openshift: https://chaos-mesh.org/docs/faqs/

How do you think about it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants