Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade the base image of chaos-dlv #4408

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kaaass
Copy link

@kaaass kaaass commented Apr 28, 2024

What problem does this PR solve?

The official golang image had switched to bookworm for default version tag (golang:1.20). However, the current dlv image is still using debian:buster, which would cause a glibc compatibility issue and make the container exited unexpectedly.

To reproduce the issue, just simply run the command in documentation: helm upgrade --install chaos-mesh-debug ./helm/chaos-mesh --namespace=chaos-mesh-debug --create-namespace --set chaosDlv.enable=true --set controllerManager.leaderElection.enabled=false. Most pods should stuck in the state CrashLoopBackOff. Logs of dlv container would like:

/dlv: /lib/aarch64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by /dlv)
/dlv: /lib/aarch64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /dlv)

What's changed and how it works?

This PR upgrades the dlv image from debian:buster to debian:bookworm. Also, to prevent silent faults caused by changes of upstream golang image, this PR changes the golang image tag to the one that explicitly specified the debian version (golang:1.20-bookworm).

Related changes

  • This change also requires further updates to the website (e.g. docs)
  • This change also requires further updates to the UI interface

Cherry-pick to release branches (optional)

This PR should be cherry-picked to the following release branches:

  • release-2.6
  • release-2.5

Checklist

CHANGELOG

Must include at least one of them.

  • I have updated the CHANGELOG.md
  • I have labeled this PR with "no-need-update-changelog"

Tests

Must include at least one of them.

  • Unit test
  • E2E test
  • Manual test

Side effects

  • Breaking backward compatibility

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

Signed-off-by: KAAAsS <admin@kaaass.net>
@STRRL
Copy link
Member

STRRL commented May 14, 2024

/approve
/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants