fix(integration test): upgrade localstack #4430
Conversation
Signed-off-by: Zhou Zhiqiang <im@strrl.dev>
STRRL
added
the
no-need-update-changelog
Signed-off-by: Zhou Zhiqiang <im@strrl.dev>
STRRL
force-pushed
the
fix-integration-test
branch
from
c505ff5
to
ffba074
Compare
Signed-off-by: STRRL <im@strrl.dev>
Signed-off-by: Zhou Zhiqiang <im@strrl.dev>
Signed-off-by: Zhou Zhiqiang <im@strrl.dev>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: STRRL The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
this PR fix the broken integration tests, PTAL @g1eny0ung |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4430 +/- ##
==========================================
+ Coverage 38.71% 38.83% +0.11%
==========================================
Files 169 169
Lines 13953 13953
==========================================
+ Hits 5402 5418 +16
+ Misses 8103 8090 -13
+ Partials 448 445 -3 see 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| @@ -106,8 +106,8 @@ jobs: | |||
| make chaosctl | |||
| - name: Install localstack && aws client | |||
| run: | | |||
| helm repo add localstack-repo http://helm.localstack.cloud | |||
| helm upgrade --install localstack localstack-repo/localstack --version 0.1.2 | |||
| helm repo add localstack-repo http://helm.localstack.cloud && helm repo update | |||
There was a problem hiding this comment.
@STRRL Should we need to run helm repo update? The helm repo add command should already get the latest version. 🤔
There was a problem hiding this comment.
Yes, you're right, we do not need helm repo update for environments in github actions.
g1eny0ung
changed the title
Signed-off-by: STRRL <im@strrl.dev>
What problem does this PR solve?
What's changed and how it works?
Related changes
UI interfaceCherry-pick to release branches (optional)
Checklist
CHANGELOG
CHANGELOG.mdTests
Side effects
DCO
If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it: