Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: integrate helm-values-schema-json to generate schema for values.yaml #4435

Merged
merged 11 commits into from
Jun 19, 2024

Conversation

g1eny0ung
Copy link
Member

Signed-off-by: Yue Yang g1enyy0ung@gmail.com

What problem does this PR solve?

Close #4310

What's changed and how it works?

Install helm-values-schema-json in the dev-env image and add a target named helm-values-schema in the Makefile.

Related changes

  • This change also requires further updates to the website (e.g. docs)
  • This change also requires further updates to the UI interface

Cherry-pick to release branches (optional)

This PR should be cherry-picked to the following release branches:

  • release-2.6
  • release-2.5

Checklist

CHANGELOG

Must include at least one of them.

  • I have updated the CHANGELOG.md
  • I have labeled this PR with "no-need-update-changelog"

Tests

Must include at least one of them.

  • Unit test
  • E2E test
  • Manual test

Side effects

  • Breaking backward compatibility

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
@chaotic-prow
Copy link

chaotic-prow bot commented Jun 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from g1eny0ung. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
@g1eny0ung g1eny0ung merged commit 5887f7f into chaos-mesh:master Jun 19, 2024
53 of 56 checks passed
@g1eny0ung g1eny0ung deleted the helm-values-schema branch June 19, 2024 08:40
g1eny0ung added a commit to g1eny0ung/chaos-mesh that referenced this pull request Jun 19, 2024
g1eny0ung added a commit to g1eny0ung/chaos-mesh that referenced this pull request Jun 19, 2024
…s.yaml (chaos-mesh#4435)

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
g1eny0ung added a commit that referenced this pull request Jun 19, 2024
* feat: allow annotations on controller manager and daemon ServiceAccount (#4106)

Signed-off-by: Philipp Tanlak <philipp.tanlak@form3.tech>

* chore: add service account creation as optional and allow podSecurity (#4390)

Co-authored-by: Yue Yang <g1enyy0ung@gmail.com>
Co-authored-by: Abby Watterson <Abby.Watterson@fmr.com>

* chore: integrate helm-values-schema-json to generate schema for values.yaml (#4435)

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

---------

Signed-off-by: Philipp Tanlak <philipp.tanlak@form3.tech>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Co-authored-by: Philipp Tanlak <93513276+philipptanlak-form3@users.noreply.github.com>
Co-authored-by: Abby Watterson <47790508+awatterson22@users.noreply.github.com>
Co-authored-by: Abby Watterson <Abby.Watterson@fmr.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD component/helm rebuild-dev-env-image rebuild dev-env image in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate helm-values-schema-json for updating helm values schema in Makefile
1 participant