Fix stress chaos map (#853) #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
|
/run-all-tests |
cwen0
approved these changes
Aug 26, 2020
Oh! Sorry. I have signed an "Approve" for my PR 😿 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #853 to release-0.9
What problem does this PR solve?
A possible solution to #847
What is changed and how does it work?
Fix two bugs:
Instances map is not protected with a lock 😠
Check instances before applying chaos. This will fix extra
stress-ngprocesses due to fail and retry.The logic about retrying in chaos-mesh is really chaos 😿 . We should improve it in near-future #851 .
And, sorry for not finding these bugs when I was reviewing. I'm still not adapted with dealing these problems without the help of compiler or other tools...
Checklist
Tests