feat: add hostNetwork option for controller-manager and update doc accordingly #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cordingly. Signed-off-by: colstuwjx <colstuwjx@gmail.com>
Colstuwjx
force-pushed
the
feat/chart-controller-hostnet
branch
from
df2ae38
to
e663742
Compare
cwen0
approved these changes
Sep 7, 2020
ti-srebot
approved these changes
Sep 7, 2020
|
/merge |
|
/run-all-tests |
STRRL
pushed a commit
to STRRL/chaos-mesh
that referenced
this pull request
Sep 10, 2020
…cordingly (chaos-mesh#874) Signed-off-by: colstuwjx <colstuwjx@gmail.com> Signed-off-by: STRRL <str_ruiling@outlook.com>
sjwsl
pushed a commit
to sjwsl/chaos-mesh
that referenced
this pull request
May 6, 2021
…cordingly (chaos-mesh#874) Signed-off-by: colstuwjx <colstuwjx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
In our helm chart, the controller-manager didn't support
hostNetwork=true, and for me, it's quite need, so I proposed this PR.What is changed and how does it work?
Updated the
controller-manager-deployment.yamland add hostNetwork option support, by default, it's false, so there is nothing changed if we're keep using the original values.