Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[update] add status.FailedMessage in Release 1.0 #931

Merged
merged 2 commits into from
Sep 21, 2020
Merged

[update] add status.FailedMessage in Release 1.0 #931

merged 2 commits into from
Sep 21, 2020

Conversation

fewdan
Copy link
Member

@fewdan fewdan commented Sep 21, 2020

What problem does this PR solve?

#854

What is changed and how does it work?

Record the error information on the crd object.
Now that there is no error message recorded on the crd object, it is not convenient for the dashboard to display the error message, so record the failedMessage.

Checklist

Tests

  • Unit test
  • E2E test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Breaking backward compatibility

Related changes

  • Need to update the documentation

Does this PR introduce a user-facing change?

NONE

Signed-off-by: “fewdan” <fewdan@hotmail.com>
Signed-off-by: “fewdan” <fewdan@hotmail.com>
Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0 cwen0 merged commit e26d134 into chaos-mesh:release-1.0 Sep 21, 2020
@fewdan fewdan deleted the release-1.0 branch September 21, 2020 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants