.*: implement the DNS chaos CRD API #935

WangXiangUSTC · 2020-09-21T08:55:17Z

What problem does this PR solve?

Add a new CRD DNS chaos, and implement this CRD's API.

This pr is part of #860, #860 is too big, so I will split it to multiple small prs.

Checklist

Tests

Unit test
E2E test
Manual test (add detailed scripts or steps below)
No code

Side effects

Breaking backward compatibility

Related changes

Need to update the documentation

Does this PR introduce a user-facing change?

NONE

Signed-off-by: xiang <xiang13225080@163.com>

codecov-commenter · 2020-09-21T09:20:34Z

Codecov Report

Merging #935 into master will decrease coverage by 7.16%.
The diff coverage is 28.08%.

@@            Coverage Diff             @@
##           master     #935      +/-   ##
==========================================
- Coverage   55.78%   48.61%   -7.17%     
==========================================
  Files          68       76       +8     
  Lines        4383     4371      -12     
==========================================
- Hits         2445     2125     -320     
- Misses       1768     2042     +274     
- Partials      170      204      +34

Impacted Files	Coverage Δ
api/v1alpha1/common_validation.go	`100.00% <ø> (ø)`
api/v1alpha1/common_webhook.go	`100.00% <ø> (ø)`
api/v1alpha1/dnschaos_webhook.go	`0.00% <0.00%> (ø)`
api/v1alpha1/iochaos_types.go	`37.03% <0.00%> (-2.97%)`	⬇️
api/v1alpha1/kernelchaos_types.go	`18.51% <0.00%> (-1.49%)`	⬇️
api/v1alpha1/kernelchaos_webhook.go	`84.21% <ø> (-0.98%)`	⬇️
api/v1alpha1/kinds.go	`27.27% <ø> (+0.60%)`	⬆️
api/v1alpha1/networkchaos_types.go	`19.54% <0.00%> (-3.44%)`	⬇️
api/v1alpha1/podchaos_types.go	`33.33% <0.00%> (-3.81%)`	⬇️
api/v1alpha1/podchaos_webhook.go	`80.76% <ø> (-1.20%)`	⬇️
... and 123 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af2d2a1...23812f1. Read the comment docs.

WangXiangUSTC · 2020-09-21T09:21:16Z

/run-all-tests

Signed-off-by: xiang <xiang13225080@163.com>

Gallardot

Rest LGTM

Gallardot · 2020-09-29T02:13:21Z

api/v1alpha1/dnschaos_webhook.go

+	return ValidatePodMode(in.Spec.Value, in.Spec.Mode, spec.Child("value"))
+}
+
+func (in *DNSChaosSpec) validateAction(action *field.Path) field.ErrorList {


I found a similar logic above using kubebuilder:validation.

// +kubebuilder:validation:Enum=error;random Action DNSChaosAction `json:"action"`

kubebuilder:validation is enough.
I don't think this method is necessary at present.

OK, I removed these two functions

Gallardot · 2020-09-29T02:14:32Z

api/v1alpha1/dnschaos_webhook.go

+	return allErrs
+}
+
+func (in *DNSChaosSpec) validateScope(scope *field.Path) field.ErrorList {


ditto

// +kubebuilder:validation:Enum=outer;inner;all Scope DNSChaosScope `json:"scope"`

Signed-off-by: xiang <xiang13225080@163.com>

fewdan

LGTM

codecov-io · 2020-10-09T08:06:09Z

Codecov Report

Merging #935 into master will decrease coverage by 8.38%.
The diff coverage is 26.40%.

@@            Coverage Diff             @@
##           master     #935      +/-   ##
==========================================
- Coverage   55.78%   47.40%   -8.39%     
==========================================
  Files          68       72       +4     
  Lines        4383     4367      -16     
==========================================
- Hits         2445     2070     -375     
- Misses       1768     2087     +319     
- Partials      170      210      +40

Impacted Files	Coverage Δ
api/v1alpha1/common_types.go	`0.00% <0.00%> (ø)`
api/v1alpha1/common_validation.go	`100.00% <ø> (ø)`
api/v1alpha1/common_webhook.go	`100.00% <ø> (ø)`
api/v1alpha1/dnschaos_type.go	`0.00% <0.00%> (ø)`
api/v1alpha1/dnschaos_webhook.go	`0.00% <0.00%> (ø)`
api/v1alpha1/httpchaos_types.go	`0.00% <0.00%> (ø)`
api/v1alpha1/iochaos_types.go	`0.00% <ø> (-40.00%)`	⬇️
api/v1alpha1/kernelchaos_types.go	`0.00% <ø> (-20.00%)`	⬇️
api/v1alpha1/kernelchaos_webhook.go	`100.00% <ø> (+14.81%)`	⬆️
api/v1alpha1/kinds.go	`27.27% <ø> (+0.60%)`	⬆️
... and 113 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf9e1ca...4e42158. Read the comment docs.

WangXiangUSTC · 2020-10-10T02:57:46Z

@Gallardot PTAL again

YangKeao

LGTM

cwen0 · 2020-10-10T07:37:48Z

@WangXiangUSTC Do we need to update helm files and install.sh?

Signed-off-by: xiang <xiang13225080@163.com>

WangXiangUSTC · 2020-10-10T10:43:32Z

@WangXiangUSTC Do we need to update helm files and install.sh?

OK, seems that I forget to update them

Signed-off-by: xiang <xiang13225080@163.com>

WangXiangUSTC · 2020-10-12T09:20:28Z

@cwen0 this pr is refactored by chaos-builder, PTAL again

cwen0

LGTM

Gallardot

LGTM

WangXiangUSTC · 2020-10-13T05:40:53Z

/merge

ti-srebot · 2020-10-13T05:43:23Z

/run-all-tests

WangXiangUSTC added 2 commits September 21, 2020 16:49

add api for dns chaos

60e21da

Signed-off-by: xiang <xiang13225080@163.com>

minor update

b1d89ba

Signed-off-by: xiang <xiang13225080@163.com>

WangXiangUSTC added the status/PTAL label Sep 21, 2020

WangXiangUSTC added 2 commits September 21, 2020 17:08

merge master && resolve conflicts

7798c35

Signed-off-by: xiang <xiang13225080@163.com>

update install.sh

23812f1

Signed-off-by: xiang <xiang13225080@163.com>

WangXiangUSTC added 2 commits September 23, 2020 10:39

add reader

d5f5b9c

Signed-off-by: xiang <xiang13225080@163.com>

merge master

60dac85

Signed-off-by: xiang <xiang13225080@163.com>

cwen0 requested review from Gallardot, YangKeao, fewdan and cwen0 September 28, 2020 07:55

Gallardot requested changes Sep 29, 2020

View reviewed changes

WangXiangUSTC added 2 commits September 30, 2020 11:13

remove duplicate validate

8158d03

Signed-off-by: xiang <xiang13225080@163.com>

go mod tidy

596c4f8

Signed-off-by: xiang <xiang13225080@163.com>

fewdan previously approved these changes Oct 9, 2020

View reviewed changes

ti-srebot added the status/LGT1 label Oct 9, 2020

Merge branch 'master' into xiang/dns_chaos_api

bc3b7f0

YangKeao previously approved these changes Oct 10, 2020

View reviewed changes

ti-srebot removed the status/LGT1 label Oct 10, 2020

ti-srebot previously approved these changes Oct 10, 2020

View reviewed changes

ti-srebot added the status/LGT2 label Oct 10, 2020

update helm and install.sh

2c29f32

Signed-off-by: xiang <xiang13225080@163.com>

WangXiangUSTC dismissed stale reviews from ti-srebot, YangKeao, and fewdan via 2c29f32 October 10, 2020 10:23

WangXiangUSTC added 3 commits October 12, 2020 16:08

Merge remote-tracking branch 'remote/master' into xiang/dns_chaos_api

69d1f28

generate code automatic

553009f

Signed-off-by: xiang <xiang13225080@163.com>

remove useless file

4e42158

Signed-off-by: xiang <xiang13225080@163.com>

Merge branch 'master' into xiang/dns_chaos_api

dc10f40

cwen0 approved these changes Oct 13, 2020

View reviewed changes

Gallardot approved these changes Oct 13, 2020

View reviewed changes

ti-srebot added the status/can-merge label Oct 13, 2020

Merge branch 'master' into xiang/dns_chaos_api

a55836f

ti-srebot merged commit 8505f11 into chaos-mesh:master Oct 13, 2020

WangXiangUSTC deleted the xiang/dns_chaos_api branch October 13, 2020 05:48

sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021

.*: implement the DNS chaos CRD API (chaos-mesh#935)

56b8322

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

.*: implement the DNS chaos CRD API #935

.*: implement the DNS chaos CRD API #935

WangXiangUSTC commented Sep 21, 2020 •

edited

Loading

codecov-commenter commented Sep 21, 2020

WangXiangUSTC commented Sep 21, 2020

Gallardot left a comment

Gallardot Sep 29, 2020 •

edited

Loading

WangXiangUSTC Sep 30, 2020

Gallardot Sep 29, 2020

WangXiangUSTC Oct 9, 2020

fewdan left a comment

codecov-io commented Oct 9, 2020 •

edited

Loading

WangXiangUSTC commented Oct 10, 2020

YangKeao left a comment

cwen0 commented Oct 10, 2020

WangXiangUSTC commented Oct 10, 2020

WangXiangUSTC commented Oct 12, 2020

cwen0 left a comment

Gallardot left a comment

WangXiangUSTC commented Oct 13, 2020

ti-srebot commented Oct 13, 2020

.*: implement the DNS chaos CRD API #935

.*: implement the DNS chaos CRD API #935

Conversation

WangXiangUSTC commented Sep 21, 2020 • edited Loading

What problem does this PR solve?

Checklist

Does this PR introduce a user-facing change?

codecov-commenter commented Sep 21, 2020

Codecov Report

WangXiangUSTC commented Sep 21, 2020

Gallardot left a comment

Choose a reason for hiding this comment

Gallardot Sep 29, 2020 • edited Loading

Choose a reason for hiding this comment

WangXiangUSTC Sep 30, 2020

Choose a reason for hiding this comment

Gallardot Sep 29, 2020

Choose a reason for hiding this comment

WangXiangUSTC Oct 9, 2020

Choose a reason for hiding this comment

fewdan left a comment

Choose a reason for hiding this comment

codecov-io commented Oct 9, 2020 • edited Loading

Codecov Report

WangXiangUSTC commented Oct 10, 2020

YangKeao left a comment

Choose a reason for hiding this comment

cwen0 commented Oct 10, 2020

WangXiangUSTC commented Oct 10, 2020

WangXiangUSTC commented Oct 12, 2020

cwen0 left a comment

Choose a reason for hiding this comment

Gallardot left a comment

Choose a reason for hiding this comment

WangXiangUSTC commented Oct 13, 2020

ti-srebot commented Oct 13, 2020

WangXiangUSTC commented Sep 21, 2020 •

edited

Loading

Gallardot Sep 29, 2020 •

edited

Loading

codecov-io commented Oct 9, 2020 •

edited

Loading