Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pod deletion caused twophase phase=Failed chaos. (#946) #949

Merged

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #946 to release-1.0


What problem does this PR solve?

Fixed #944 , addressed by the issue comment.

What is changed and how does it work?

If networkchaos is Failed phase, it may need retry apply, and this PR help it come true!

Checklist

Tests

  • Unit test
  • E2E test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Breaking backward compatibility

Related changes

  • Need to update the documentation

Does this PR introduce a user-facing change?

No

NONE

Signed-off-by: colstuwjx <colstuwjx@gmail.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

Copy link
Contributor

@zhouqiang-cl zhouqiang-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouqiang-cl zhouqiang-cl merged commit 378ac75 into chaos-mesh:release-1.0 Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants